Mutable polyhedron (ppl) saves incorrect Vrepresentation

[kliem]

sage: P = polytopes.cube()
sage: Q = 1/2*P
sage: parent = P.parent()
sage: R = parent._element_constructor_(Q, mutable=True)
sage: R
/home/jonathan/Applications/sage/local/lib/python3.8/site-packages/sage/repl/rich_output/display_manager.py:608: RichReprWarning: Exception in _rich_repr_ while displaying object: no conversion of this rational to integer
  warnings.warn(
The empty polyhedron in ZZ^3
sage: R.Hrepresentation()
(An inequality (0, 0, -2) x + 1 >= 0,
 An inequality (0, -2, 0) x + 1 >= 0,
 An inequality (-2, 0, 0) x + 1 >= 0,
 An inequality (2, 0, 0) x + 1 >= 0,
 An inequality (0, 0, 2) x + 1 >= 0,
 An inequality (0, 2, 0) x + 1 >= 0)
sage: R.Vrepresentation()
[]

While obtaining the Vrepresentation from the backend, a TypeError is not handled properly. We end up with a broken object, which isn't communicated well to the user.

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: ed109ae

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33666

[kliem]

Branch: public/33666

[kliem]

New commits:

1b18639

clear cache after catching type error when obtaining Vrepresentation

[kliem]

Commit: 1b18639

[mkoeppe]

comment:5

Patchbot says

sage -t --long --random-seed=33333237385512314714344203620105943909 src/sage/geometry/polyhedron/constructor.py
**********************************************************************
File "src/sage/geometry/polyhedron/constructor.py", line 522, in sage.geometry.polyhedron.constructor.?
Failed example:
    Q = Polyhedron(vertices=[(1, 2, 3), (1, 3, 2), (2, 1, 3),
                             (2, 3, 1), (3, 1, 2), (3, 2, 1)],
                   rays=[[1, 1, 1]], lines=[[1, 2, 3]], backend='ppl',
                   base_ring=ZZ)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ebe930a

keep old type error at initialization

[sagetrac-git]

Changed commit from 1b18639 to ebe930a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f635ad1	clear cache after catching type error when obtaining Vrepresentation
ed109ae	keep old type error at initialization

[sagetrac-git]

Changed commit from ebe930a to ed109ae

[mkoeppe]

Reviewer: Matthias Koeppe

[kliem]

comment:10

Thank you.

[vbraun]

Changed branch from public/33666 to ed109ae