Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface to nauty-gentreeg (generator of trees) #33670

Closed
dcoudert opened this issue Apr 10, 2022 · 13 comments
Closed

Add interface to nauty-gentreeg (generator of trees) #33670

dcoudert opened this issue Apr 10, 2022 · 13 comments

Comments

@dcoudert
Copy link
Contributor

Add interface to Nauty's gentreeg generator of non-isomorphic trees.

It is slower than graphs.trees() but has more options.

Component: graph theory

Author: David Coudert

Branch: 7a5e122

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/33670

@dcoudert dcoudert added this to the sage-9.6 milestone Apr 10, 2022
@dcoudert
Copy link
Contributor Author

Branch: public/graphs/33670_gentreeg

@dcoudert
Copy link
Contributor Author

New commits:

077a46ftrac #33670: add interface to nauty's gentreeg

@dcoudert
Copy link
Contributor Author

Commit: 077a46f

@fchapoton
Copy link
Contributor

comment:2

typo "aggrees"

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 14, 2022

Changed commit from 077a46f to 7a5e122

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

7a5e122trac #33670: fix typo

@dcoudert
Copy link
Contributor Author

comment:4

fixed.

@fchapoton
Copy link
Contributor

comment:5

feu vert

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from public/graphs/33670_gentreeg to 7a5e122

@mkoeppe
Copy link
Member

mkoeppe commented Jul 8, 2022

Changed commit from 7a5e122 to none

@mkoeppe
Copy link
Member

mkoeppe commented Jul 8, 2022

comment:7

I've seen a few failures related to this on CI. For example
https://github.com/mkoeppe/sage/runs/7244909758?check_suite_focus=true

sage -t --random-seed=339975412379786288587528093076040376748 src/sage/graphs/generators/families.py
**********************************************************************
File "src/sage/graphs/generators/families.py", line 3479, in sage.graphs.generators.families.nauty_gentreeg
Failed example:
    [len(list(graphs.nauty_gentreeg(str(i)))) for i in range(1, 15)]
Expected:
    [1, 1, 1, 2, 3, 6, 11, 23, 47, 106, 235, 551, 1301, 3159]
Got:
    [1, 2, 1, 2, 3, 6, 11, 23, 47, 106, 235, 551, 1301, 3159]

(that's on debian-stretch-standard using system nauty 2.6r7+ds-1)

@mkoeppe
Copy link
Member

mkoeppe commented Jul 8, 2022

comment:8

I've opened #34133 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants