Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make representation integers exportable and small improvements to backend ppl #33678

Closed
kliem opened this issue Apr 11, 2022 · 7 comments
Closed

Make representation integers exportable and small improvements to backend ppl #33678

kliem opened this issue Apr 11, 2022 · 7 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@kliem
Copy link
Contributor

kliem commented Apr 11, 2022

In backend_ppl.py we currently manually copy the integers representing the different representation types in representation.py. In this ticket we change this to an import. This is easier to read and less error prone.

In addition we outsource to abstract methods to create a ppl generator resp. constraint system.

CC: @tscrim @yuan-zhou @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 94bd1ee

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33678
@kliem kliem added this to the sage-9.6 milestone Apr 11, 2022
@kliem
Copy link
Contributor Author

kliem commented Apr 11, 2022

Branch: public/33678

@kliem
Copy link
Contributor Author

kliem commented Apr 11, 2022

New commits:

6e8740fuse types directly from representation.py
94bd1eeoutsource creating of ppl generator/constraint system

@kliem
Copy link
Contributor Author

kliem commented Apr 11, 2022

Commit: 94bd1ee

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@tscrim
Copy link
Collaborator

tscrim commented Apr 11, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 11, 2022

comment:3

Personally, I am not a fan of the @staticmethod, but since that is what is done for other conversion functions, let it be so.

@kliem
Copy link
Contributor Author

kliem commented Apr 12, 2022

comment:4

Thank you.

@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from public/33678 to 94bd1ee

@vbraun vbraun closed this as completed in cb9d6aa May 22, 2022
@kliem kliem mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @tscrim @mkoeppe @kliem