Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept giac-1.9.x from system #33717

Closed
tornaria opened this issue Apr 15, 2022 · 8 comments
Closed

Accept giac-1.9.x from system #33717

tornaria opened this issue Apr 15, 2022 · 8 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@tornaria
Copy link
Contributor

Upstream has recently bumped giac to 1.9.0 (https://xcas.univ-grenoble-alpes.fr/forum/viewtopic.php?f=8&t=2775) but there is no significant difference from 1.7.0-57 and doctests pass just fine on 9.6.rc0.

CC: @orlitzky @antonio-rojas @kiwifb @mkoeppe

Component: build: configure

Author: Gonzalo Tornaría

Branch: e4f814d

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33717
@tornaria tornaria added this to the sage-9.6 milestone Apr 15, 2022
@tornaria
Copy link
Contributor Author

Author: Gonzalo Tornaría

@tornaria
Copy link
Contributor Author

Commit: e4f814d

@tornaria
Copy link
Contributor Author

Branch: u/tornaria/33717

@tornaria
Copy link
Contributor Author

comment:1

Maybe GIAC_MAX_VERSION should be removed?

New commits:

e4f814dTrac #33717: accept giac-1.9.x from the system

@mkoeppe
Copy link
Member

mkoeppe commented Apr 15, 2022

Reviewer: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 15, 2022
@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from u/tornaria/33717 to e4f814d

@vbraun vbraun closed this as completed in b1f667b May 22, 2022
@jhpalmieri
Copy link
Member

comment:5

See #33877 for a problem arising from using the system's giac 1.9.x.

@jhpalmieri
Copy link
Member

Changed commit from e4f814d to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @tornaria @jhpalmieri @mkoeppe