Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixed review] Fix building ntl on Solaris with make and ld #3375

Closed
kiwifb opened this issue Jun 6, 2008 · 7 comments
Closed

[mixed review] Fix building ntl on Solaris with make and ld #3375

kiwifb opened this issue Jun 6, 2008 · 7 comments

Comments

@kiwifb
Copy link
Member

kiwifb commented Jun 6, 2008

OK so here is what got me through ntl on David's box.
The mfile patch is against the copy in the ntl patch folder
not the source. It also patch ntl spkg-install to properly
setup and tune ntl as well as cleaning the installation bits
introduced to accommodate Tim & I.
I guess Tim and I will have to fend for ourselves separately.
Also we submitted a lot of patch in the ntl style. Since
I used some GNU-ism for building shared objects most of
them will have to be revised.

Francois

CC: @sagetrac-PolyBoRi

Component: build

Keywords: editor_mabshoff

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/3375

@kiwifb kiwifb added this to the sage-5.11 milestone Jun 6, 2008
@kiwifb
Copy link
Member Author

kiwifb commented Jun 6, 2008

patch for ntl spkg-install and patch/mfile

@craigcitro
Copy link
Member

Changed keywords from none to editor_mabshoff

@craigcitro
Copy link
Member

comment:1

Attachment: ntl-sun.patch.gz

@craigcitro craigcitro changed the title Fix building ntl on Solaris with make and ld [with patch needs review] [with patch needs review] Fix building ntl on Solaris with make and ld Jun 15, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jun 20, 2008

comment:2

Hi Francois,

Unless I am overlooking something you are removing the "-fPIC" lines from the link phase. Are you sure that will work?

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [with patch needs review] Fix building ntl on Solaris with make and ld [mixed review] Fix building ntl on Solaris with make and ld Jun 20, 2008
@kiwifb
Copy link
Member Author

kiwifb commented Jun 20, 2008

comment:3

It works all right on linux (no text relocations) but I indeed
cannot guaranty it on other platform. I just checked the gcc
manual and they recommand passing the PIC flag used during
compilation as well when using -shared so best to put it back:

-shared' Produce a shared object which can then be linked with other objects to form an executable. Not all systems support this option. For predictable results, you must also specify the same set of options that were used to generate code (-fpic', `-fPIC',
or model suboptions) when you specify this option.(1)

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@kiwifb
Copy link
Member Author

kiwifb commented Feb 22, 2015

Reviewer: François Bissey

@kiwifb
Copy link
Member Author

kiwifb commented Feb 22, 2015

comment:10

Looking through old tickets this is sooo obsolete. Won't fix/invalid.

@vbraun vbraun removed this from the sage-6.4 milestone Feb 23, 2015
@vbraun vbraun closed this as completed Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants