Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with ecm-7.0.5 #33861

Closed
tornaria opened this issue May 17, 2022 · 9 comments
Closed

Incompatibility with ecm-7.0.5 #33861

tornaria opened this issue May 17, 2022 · 9 comments

Comments

@tornaria
Copy link
Contributor

ecm-7.0.5 was released a couple of weeks ago, output was slightly changed making ecm.time() broken. Unfortunately I didn't doctest sage after rc3 and before the final 9.6 so I didn't catch it in time.

Actual failures:

**********************************************************************
File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 717, in sage.interfaces.ecm.ECM.time
Failed example:
    ecm.time(n, 35)                  # random output
Exception raised:
    Traceback (most recent call last):
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.ecm.ECM.time[1]>", line 1, in <module>
        ecm.time(n, Integer(35))                  # random output
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 770, in time
        while next(out_lines) != title_curves:
    StopIteration
**********************************************************************
File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 720, in sage.interfaces.ecm.ECM.time
Failed example:
    ecm.time(n, 30, verbose=True)     # random output
Exception raised:
    Traceback (most recent call last):
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)                                                                                                                                 
      File "<doctest sage.interfaces.ecm.ECM.time[2]>", line 1, in <module>                                                                                   
        ecm.time(n, Integer(30), verbose=True)     # random output
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 770, in time
        while next(out_lines) != title_curves:
    StopIteration
**********************************************************************

Component: interfaces

Branch/Commit: u/tornaria/33861 @ 7df4dd1

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33861

@tornaria tornaria added this to the sage-9.7 milestone May 17, 2022
@tornaria
Copy link
Contributor Author

Commit: 7df4dd1

@tornaria
Copy link
Contributor Author

Author: Gonzalo Tornaría

@tornaria
Copy link
Contributor Author

Branch: u/tornaria/33861

@tornaria
Copy link
Contributor Author

comment:1

This seems to work, tested with ecm-7.0.4 and ecm-7.0.5.


New commits:

7df4dd1Trac #33861: fix ecm.time() so it works with ecm-7.0.5

@tornaria
Copy link
Contributor Author

comment:2

#31325 includes a patch with similar effect to this, so this one can be dropped if that ticket is merged. Sorry for the noise.

@mkoeppe
Copy link
Member

mkoeppe commented May 17, 2022

comment:3

dup of #31325

@mkoeppe
Copy link
Member

mkoeppe commented May 17, 2022

Changed author from Gonzalo Tornaría to none

@mkoeppe mkoeppe removed this from the sage-9.7 milestone May 17, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Jul 29, 2022

comment:4

Yes.

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 29, 2022

Reviewer: Kwankyu Lee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants