Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of some range(0,*) in pyx files #33889

Closed
fchapoton opened this issue May 24, 2022 · 11 comments
Closed

get rid of some range(0,*) in pyx files #33889

fchapoton opened this issue May 24, 2022 · 11 comments

Comments

@fchapoton
Copy link
Contributor

We replace some range(0, a) by range(a),
occasionally replacing xrange by range
or a list by an iterator.

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: d2a9eb6

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/33889

@fchapoton fchapoton added this to the sage-9.7 milestone May 24, 2022
@fchapoton
Copy link
Contributor Author

Commit: 3b88284

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33889

@fchapoton
Copy link
Contributor Author

New commits:

3b88284get rid of some range(O,*)

@slel
Copy link
Member

slel commented May 24, 2022

comment:2

J'approuve.

@slel

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented May 24, 2022

comment:3

Merge failure on top of:

7088517 Trac #33845: pep cleanup for multi_polynomial_ring_base.pyx

041f643 Trac #33844: remove deprecation in matrix2

e47906b Trac #33843: remove deprecated has_key

36286c8 Trac #33837: sage.{numerical,calculus,probability}: Remove use of SAGE_TMP in doctests

028e704 Trac #33801: sage.misc.sage_input: Remove import from sage.all

2649fa7 Trac #33764: suppress cache warnings from systemwide sympow on Fedora

8bcb516 Trac #33749: set positions in butterfly digraph generator

3a99a8f Trac #33886: fixing a few roles

67d1d1d Trac #33884: use a smaller random test in edge_disjoint_spanning_trees

2f83c2e Trac #33864: Update cython to 0.29.30

517265e Trac #7989: Minpoly doesn't work for all matrices

7c5c452 Trac #33887: Fix map_reduce doctest, part 2

3666d4a Trac #33792: documentation of save_session refers to the old sagenb

bbe8511 Trac #33762: fine tuning details in Tamari interval posets

4018507 Trac #33742: add see also blocks in orientation methods

18b7c88 Trac #33732: get rid of unused variables in algebra

1753073 Trac #33726: get rid of some iteritems

3202aea Trac #33721: better boolean statements

22de1a0 Trac #33715: various code formatting details in pyx files in combinat

f0d36a0 Trac #33714: clean group_semidirect_product.py (pep8 and doc)

c775c27 Trac #33712: adjust error messages in arith/

fd6379f Trac #33696: simplify some isinstance

7a8aa66 Trac #33690: some details in symbolic

cf7d877 Trac #33669: pep cleanup for tableau_tuple

5d3168b Trac #33668: remove class inheritance of object in various places

6ef564d Trac #33667: fix and activate pycodestyle E703 in pyx files

63db311 Trac #33617: sage.modules.fg_pid.fgp_module: Rename a test_... function to test... (with deprecation)

b35733c Trac #33234: Fix randrange deprecation warning with python-3.10

3c6ce75 Trac #33124: Add pictures to point.py documentation

8c00611 Trac #33016: Fix global import of sage.repl.rich_output.display_manager.get_display_manager

8a631eb Trac #28598: Documentation error for Stein-Watkins database

f5c86b9 Trac #27522: implement Conway polynomial

98e21b8 Trac #25626: Add doctest for integrating exp(t)/(t + 1)^2 with giac

0039cce Trac #33867: tweak our .lgtm file, add documentation

7de9262 Trac #33858: Further parallelization for fundamental group of curves.

a357cf7 Trac #33847: Bug in h_star_vector for polytopes with the normaliz backend

f69c9b8 Trac #33838: Refactoring run_autogen [to generate wrappers] to pkgs/sagemath-standard/setup.py

2bb3b14 Trac #33831: deprecate unused PermutationGroup_generic.has_element

c4f35cf Trac #33786: Top-level sage script: Unconditionally set SAGE_ROOT

83a89a0 Trac #33784: provide a framework for finite group actions

fa3b529 Trac #25833: Upgrade to MathJax 3 and configure Sage

e2ebf44 Trac #33825: Use pytest-xdist to run pytest in parallel

b400962 Trac #33824: make gens and orbits of PermutationGroup immutable

af23627 Trac #33809: some pathlib in combinat and groups

955b5d9 Trac #33803: Fixes for the distributions sagemath-objects, sagemath-categories

3e6b41f Trac #33799: Replace SAGE_TMP in doctests of sage.misc.{persist,ostools}, sage.doctest, sage.repl

a3fd718 Trac #33797: sage.misc.temporary_file: Remove use of SAGE_TMP

2ca0530 Trac #33794: modules/fp_graded/morphism.py test failure

7037fba Trac #33793: sage.misc.cython: Replace use of SPYX_TMP by a new cached function in sage.misc.temporary_file

d115270 Trac #33787: Installation manual: Update section "system-wide install"

0ae5565 Trac #33782: ci-cygwin: Update python version

833f53d Trac #33779: Remove use of SAGE_TMP in sage.interfaces.latte

b376a8d Trac #33771: SSLContext needs an argument

df168c8 Trac #33763: Refactor src/sage/docs

9597eaf Trac #33748: make accessing coefficients of finite-field elements easier

f02236f Trac #33744: Compute bases/circuits in MatroidUnion

8943dc0 Trac #33743: Faster random tree generator

773ec37 Trac #33740: Add conda dev environment

5e65c16 Trac #33734: variety() for polynomial systems over ℚ using msolve

8e7dcca Trac #33733: allow to use flint for Stirling numbers

6f4efb0 Updated SageMath version to 9.7.beta0

reviewer '' does not look right

@fchapoton
Copy link
Contributor Author

Reviewer: Samuel Lelièvre

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 27, 2022

Changed commit from 3b88284 to d2a9eb6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 27, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

d2a9eb6Merge branch 'u/chapoton/33889' in 9.7.b1

@fchapoton
Copy link
Contributor Author

comment:6

back to positive after trivial merge

@vbraun
Copy link
Member

vbraun commented May 29, 2022

Changed branch from u/chapoton/33889 to d2a9eb6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants