Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setuptools to 63.2.0 #34177

Closed
mkoeppe opened this issue Jul 13, 2022 · 11 comments
Closed

Update setuptools to 63.2.0 #34177

mkoeppe opened this issue Jul 13, 2022 · 11 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 13, 2022

https://setuptools.pypa.io/en/latest/history.html#v63-1-0

This will get rid of the annoying "package init file ... not found" warnings for namespace packages. (#33011 comment:65)

CC: @kwankyu @jhpalmieri

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: d60fa18

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/34177

@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 13, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 13, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 13, 2022

Commit: 989217f

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 13, 2022

New commits:

989217fbuild/pkgs/setuptools: Update to 63.1.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

d60fa18build/pkgs/setuptools: Update to 63.2.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Changed commit from 989217f to d60fa18

@mkoeppe mkoeppe changed the title Update setuptools to 63.1.0 Update setuptools to 63.2.0 Jul 14, 2022
@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:6

Looks good to me. Straightforward update.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 14, 2022

comment:7

Thanks!

@jhpalmieri
Copy link
Member

comment:8

By the way, I see many messages like this in package log files:

      ############################
      # Package would be ignored #
      ############################
      Python recognizes 'terminado._static' as an importable package,
      but it is not listed in the `packages` configuration of setuptools.

      'terminado._static' has been automatically added to the distribution only
      because it may contain data files, but this behavior is likely to change
      in future versions of setuptools (and therefore is considered deprecated).

      Please make sure that 'terminado._static' is included as a package by using
      the `packages` configuration field or the proper discovery methods
      (for example by using `find_namespace_packages(...)`/`find_namespace:`
      instead of `find_packages(...)`/`find:`).

      You can read more about "package discovery" and "data files" on setuptools
      documentation page.

(There are lots of hits for "Package would be ignored".) This is unaffected by the update to setuptools. Is this something to worry about?

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 19, 2022

comment:9

This is a warning about a future breaking change in setuptools. When we do the update to the future version in which this change is done, we'll have to update all packages that currently show this warning. Nothing to worry about.

@vbraun
Copy link
Member

vbraun commented Aug 1, 2022

Changed branch from u/mkoeppe/update_setuptools_to_63_1_0 to d60fa18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants