Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

univariate polynomial quo_rem 0 trouble #3428

Closed
burcin opened this issue Jun 15, 2008 · 8 comments
Closed

univariate polynomial quo_rem 0 trouble #3428

burcin opened this issue Jun 15, 2008 · 8 comments

Comments

@burcin
Copy link

burcin commented Jun 15, 2008

Attached patch fixes this:

sage: R.<x> = ZZ[]
sage: 0//(2*x)
---------------------------------------------------------------------------
ArithmeticError                           Traceback (most recent call last)

...
/home/burcin/work/sage/sage-3.0.2/polynomial_integer_dense_ntl.pyx in sage.rings.polynomial.polynomial_integer_dense_ntl.Polynomial_integer_dense_ntl.quo_rem (sage/rings/polynomial/polynomial_integer_dense_ntl.cpp:4638)()

ArithmeticError: division not exact in Z[x] (consider coercing to Q[x] first) 

Component: basic arithmetic

Keywords: editor_craigcitro

Issue created by migration from https://trac.sagemath.org/ticket/3428

@burcin burcin added this to the sage-3.1.1 milestone Jun 15, 2008
@burcin
Copy link
Author

burcin commented Jun 15, 2008

univariate poly quo_rem zero handling fix

@craigcitro
Copy link
Member

Changed keywords from none to editor_craigcitro

@craigcitro
Copy link
Member

comment:1

Attachment: univariate_poly_quo_rem_zero.patch.gz

@craigcitro craigcitro changed the title univariate polynomial quo_rem 0 trouble [with patch, under review by ncalexan before 6/20] univariate polynomial quo_rem 0 trouble Jun 15, 2008
@burcin
Copy link
Author

burcin commented Jun 17, 2008

comment:2

This won't be necessary when #2357 is merged. I suggest we resolve this with wontfix.

@burcin burcin closed this as completed Jun 17, 2008
@craigcitro
Copy link
Member

comment:3

However, we're not going to kill the NTL interface, so this should still be fixed.

@craigcitro craigcitro reopened this Jun 17, 2008
@craigcitro
Copy link
Member

comment:4

Looks good. I added one additional doctest to make sure that the exact failure reported is now doctested.

Review by craigcitro and ncalexan.

@craigcitro craigcitro changed the title [with patch, under review by ncalexan before 6/20] univariate polynomial quo_rem 0 trouble univariate polynomial quo_rem 0 trouble Jun 19, 2008
@craigcitro
Copy link
Member

apply after Burcin's patch

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jun 23, 2008

comment:5

Attachment: trac-3428-doctest.patch.gz

Merged in Sage 3.0.4.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jun 23, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.1.1, sage-3.0.4 Jun 23, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants