-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pep8 cleanup for one file in quadratic_forms #34304
Comments
Commit: |
Branch: u/chapoton/34304 |
New commits:
|
comment:2
I think it's problematic that the imported name |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:4
ok, right. Now with a shorter filename |
comment:5
The |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
voila |
comment:8
review, please? |
comment:9
You renamed There are many Why only one module? Do you plan to change the name of other modules too? If you plan to change them all, how about the pattern And I think we should keep the original name |
comment:10
I changed only one filename to avoid controversy. My first choice for the shorter name was indeed There are also many files in the folder that already do not follow the pattern |
comment:11
Replying to @fchapoton:
I understood. But dropping a word has danger of changing the meaning. So instead of dropping a part, I suggested to add the prefix |
comment:12
Sorry, using the prefix Let's try to choose another name, that would suit everybody.. Maybe |
comment:13
If the aim is to have a short name, how about
? |
comment:14
I think these modules |
comment:15
It may make sense to change it back to the original for this ticket, and open a separate ticket for doing all renames simultaneously. |
comment:16
My 2 cents. I agree with Matthias in comment:15; we should rename all of them on one (separate) ticket. I am +1 on removing I am not so worried about comment:2; we have ways of resolving such conflicts with, e.g., |
comment:17
Replying to @mkoeppe:
+1. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:19
ok, so here is a branch not renaming the modified file |
Reviewer: Kwankyu Lee |
comment:20
LGTM. |
Changed branch from u/chapoton/34304 to |
also a few code and doc details
CC: @tscrim @kwankyu @slel @dcoudert
Component: quadratic forms
Author: Frédéric Chapoton
Branch/Commit:
15f50e0
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/34304
The text was updated successfully, but these errors were encountered: