Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source dir cleaner for editable installs #34334

Open
mkoeppe opened this issue Aug 10, 2022 · 2 comments
Open

Source dir cleaner for editable installs #34334

mkoeppe opened this issue Aug 10, 2022 · 2 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 10, 2022

We implement a simple version of sage_setup.clean.clean_install_dir for editable installs: Remove .so files and .pyc files that are leftovers from other branches, i.e., there is no corresponding source file (.pyx for .so; .py for .pyc).

This fixes incremental builds when a Cython module is replaced by a Python module of the same name, as noted in #34324 comment:3

This simple version, because it is only applied to the source directory, not an installation directory, will be safe for modularization (in contrast to clean_install_dir, see #32927).

CC: @kwankyu

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/34334

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 10, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 10, 2022

comment:1

To be checked whether it's needed at all when we switch to PEP 660 editable wheels (#34209)

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@videlec
Copy link
Contributor

videlec commented Dec 18, 2023

Is that also a problem when removing a Cython module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants