Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version upper bound for setuptools: <64.0 #34442

Closed
mkoeppe opened this issue Aug 26, 2022 · 11 comments
Closed

Set version upper bound for setuptools: <64.0 #34442

mkoeppe opened this issue Aug 26, 2022 · 11 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 26, 2022

From @saraedum on zulip:
I am building SageMath from source following the guide that uses conda packages. I find that pip install --no-build-isolation -v -v --editable src always recompiles all the extension modules.

As a fix for Sage 9.7, we set an upper bound for setuptools that excludes the new editable wheels feature introduced in 64.0.0. See #34344, #34209 for follow-ups

CC: @saraedum @isuruf @tobiasdiez @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 8ff3894

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/34442

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 26, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 26, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 26, 2022

New commits:

4196d9dbuild/pkgs/setuptools/distros/conda.txt: Use setuptools < 64

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 26, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 26, 2022

Commit: 4196d9d

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2022

Changed commit from 4196d9d to 8ff3894

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8ff3894build/pkgs/setuptools/install-requires.txt: Set upper bound

@mkoeppe

This comment has been minimized.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 27, 2022

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants