Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize super in manifolds/ #34532

Closed
fchapoton opened this issue Sep 14, 2022 · 8 comments
Closed

modernize super in manifolds/ #34532

fchapoton opened this issue Sep 14, 2022 · 8 comments
Labels
c: manifolds p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

using the short syntax super()

CC: @egourgoulhon

Component: manifolds

Author: Frédéric Chapoton

Branch/Commit: 9944678

Reviewer: Kwankyu Lee, Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/34532
@fchapoton fchapoton added this to the sage-9.8 milestone Sep 14, 2022
@fchapoton
Copy link
Contributor Author

New commits:

9944678modernize super in manifolds

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34532

@fchapoton
Copy link
Contributor Author

Commit: 9944678

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 15, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 15, 2022

comment:3

Looks well; works well.

@egourgoulhon
Copy link
Member

comment:4

LGTM as well. Thanks!

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 15, 2022

Changed reviewer from Kwankyu Lee to Kwankyu Lee, Eric Gourgoulhon

@vbraun
Copy link
Member

vbraun commented Sep 27, 2022

Changed branch from u/chapoton/34532 to 9944678

@vbraun vbraun closed this as completed in 025fdd4 Sep 27, 2022
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@vbraun @egourgoulhon @kwankyu @fchapoton