Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong link in the documentation of topological submanifolds #34565

Closed
egourgoulhon opened this issue Sep 20, 2022 · 8 comments
Closed

Fix wrong link in the documentation of topological submanifolds #34565

egourgoulhon opened this issue Sep 20, 2022 · 8 comments
Labels
c: manifolds p: minor / 4 t: bug
Milestone
sage-9.8

Comments

@egourgoulhon
Copy link
Member

The link in the OUTPUT field of the docstring of TopologicalSubmanifold.open_subset is corrected to :class:`TopologicalSubmanifold`

Component: manifolds

Author: Eric Gourgoulhon

Branch/Commit: 9584bf1

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34565
@egourgoulhon egourgoulhon added this to the sage-9.8 milestone Sep 20, 2022
@egourgoulhon
Copy link
Member Author

Author: Eric Gourgoulhon

@egourgoulhon
Copy link
Member Author

Branch: public/manifolds/fix_doc_topological_submanifolds-34565

@egourgoulhon
Copy link
Member Author

Commit: 9584bf1

@egourgoulhon
Copy link
Member Author

New commits:

9584bf1Fix wrong link in the documentation of TopologicalSubmanifold.open_subset (Trac #34565)

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 21, 2022

comment:2

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 21, 2022

Reviewer: Kwankyu Lee

@egourgoulhon
Copy link
Member Author

comment:3

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented Sep 29, 2022

Changed branch from public/manifolds/fix_doc_topological_submanifolds-34565 to 9584bf1

@vbraun vbraun closed this as completed in a9e3acb Sep 29, 2022
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @kwankyu