Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py was missing jquery.form.js, upgrade to latest version of jquery (1.2.6) and jquery.form #3475

Closed
yqiang mannequin opened this issue Jun 19, 2008 · 6 comments

Comments

@yqiang
Copy link
Mannequin

yqiang mannequin commented Jun 19, 2008

jquery.form.js somehow got dropped from setup.py, which is needed for the web interface, it does NOT function correctly without the proper jquery plugin.

This patch also upgrades jquery, jquery.form to the latest version.

Component: dsage

Keywords: editor_mabshoff

Issue created by migration from https://trac.sagemath.org/ticket/3475

@yqiang yqiang mannequin added this to the sage-3.1 milestone Jun 19, 2008
@yqiang yqiang mannequin added c: dsage labels Jun 19, 2008
@yqiang yqiang mannequin assigned williamstein Jun 19, 2008
@yqiang yqiang mannequin added the s: needs review label Jun 19, 2008
@yqiang
Copy link
Mannequin Author

yqiang mannequin commented Jun 19, 2008

Attachment: 3475_dsage_js.patch.gz

renamed patch file to include bug #

@craigcitro
Copy link
Member

Changed keywords from none to editor_mabshoff

@craigcitro craigcitro modified the milestones: sage-3.1, sage-3.1.1 Jun 20, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 2, 2008

comment:2

Yi,

can you split off the "missing jquery.form.js from setup.py" part from the jquery update? The copy part of the patch is trivial to review and will get into 3.0.4, I am not so sure about the jquery update since that should be done by somebody who works on the notebook and withb @interact for example.

Cheers,

Michael

@yqiang
Copy link
Mannequin Author

yqiang mannequin commented Jul 2, 2008

comment:3

Michael,

The jquery update is a non issue since AFAIK the notebook does not use the jquery version dsage uses.

It uses the one found here:

iapetus:~/Software/sage-3.0.3.rc0/data/extcode/notebook/javascript/jquery >

Maybe in the future we can simply provide one version, but that is another issue. Let me know if this resolves your complaint.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 3, 2008

comment:4

I agree that there are two copies of jquery and we can upgrade DSage's copy without having any repercussions on the notebook one. Positive review.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 3, 2008

comment:5

Merged in Sage 3.0.4.alpha2

@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.1.1, sage-3.0.4 Jul 3, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jul 3, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants