Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slightly polish/improve how the cython pyx caching thing works #3491

Closed
williamstein opened this issue Jun 22, 2008 · 1 comment
Closed

slightly polish/improve how the cython pyx caching thing works #3491

williamstein opened this issue Jun 22, 2008 · 1 comment

Comments

@williamstein
Copy link
Contributor

Consider this unpleasant session.

sage: hg_sage.apply('https://github.com/sagemath/sage-prod/files/10640637/sage-3119-part4.patch.gz')
Attempting to load remote file: https://github.com/sagemath/sage/files/ticket3119/sage-3119-part4.patch.gz?format=raw
Loading: [.]
cd "/Users/was/s/devel/sage" && hg status
cd "/Users/was/s/devel/sage" && hg status
cd "/Users/was/s/devel/sage" && hg import   "/Users/was/.sage/temp/teragon_2.local/2582/tmp_3.patch"
applying /Users/was/.sage/temp/teragon_2.local/2582/tmp_3.patch
sage: 
Exiting SAGE (CPU time 0m0.27s, Wall time 0m44.10s).
teragon-2:~ was$ sage -br

----------------------------------------------------------
sage: Building and installing modified SAGE library files.


Installing c_lib
scons: `install' is up to date.
running install
running build
running build_py
copying sage/libs/mwrank/interface.py -> build/lib.macosx-10.3-i386-2.5/sage/libs/mwrank
copying sage/schemes/elliptic_curves/ell_rational_field.py -> build/lib.macosx-10.3-i386-2.5/sage/schemes/elliptic_curves
running build_ext
building 'sage.libs.mwrank.mwrank' extension
error: unknown file type '.pyx' (from 'sage/libs/mwrank/mwrank.pyx')
sage: There was an error installing modified sage library code.

teragon-2:~ was$ touch ~/d/sage/sage/libs/mwrank/mwrank.pyx
teragon-2:~ was$ sage -br

----------------------------------------------------------
sage: Building and installing modified SAGE library files.


Installing c_lib
scons: `install' is up to date.
Updating Cython code....
sage/libs/mwrank/mwrank.pyx --> /Users/was/s/local//lib/python/site-packages//sage/libs/mwrank/mwrank.pyx

Building sage/libs/mwrank/mwrank.c because it depends on sage/libs/mwrank/mwrank.pyx.
python2.5 `which cython` --embed-positions --incref-local-binop -I/Users/was/s/devel/sage-review -o sage/libs/mwrank/mwrank.c sage/libs/mwrank/mwrank.pyx
Finished updating Cython code (time = 5.777133 seconds)

So applying a patch introduced a .pyx file but the cache doesn't notice it because
it is new. This is a big problem. Maybe including the latest something from the
.hg directory in the cython .pyx hash that is computed in setup.py would very nicely
fix this.

William

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/3491

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Aug 14, 2008

comment:1

This is a dupe of #3310.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Aug 14, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin removed this from the sage-3.1.1 milestone Aug 14, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant