New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pickling certain modular forms segfaults #3503
Comments
comment:1
Interestingly enough running the same computation with
valgrinds clean. Cheers, Michael |
comment:2
Ok, the offending code is this in matrix_integer_dense.pyx:
I would not be surprised if this is an overflow issue. Notice the factor According to valgrind the crash happens in Cheers, Michael |
comment:3
ok, the following makes the above case work, but it is not the real fix:
Somebody who understands the code needs to rewrite memory management here :) Cheers, Michael |
comment:4
Great work tracking this down Michael!! |
Attachment: trac-3503.patch.gz |
comment:5
Attached patch seems to fix the issue. The problem is that two extra chars were being added to the end of the array, but space was only guaranteed for one. The attached patch fixes it. Credit to myself and David Roe. |
comment:6
BRAVO! Positive review. Great work fixing my stupid terrible bug Michael, Craig, and David Roe. |
comment:7
Merged in Sage 3.0.4.alpha1 |
On Standard sage-3.0.3 on sage.math:
Valgrind says:
and
Component: modular forms
Issue created by migration from https://trac.sagemath.org/ticket/3503
The text was updated successfully, but these errors were encountered: