using "change_ring" in quadratic_forms #35248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also get rid (later) of |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35248 +/- ##
===========================================
- Coverage 88.61% 88.59% -0.02%
===========================================
Files 2148 2140 -8
Lines 398855 397417 -1438
===========================================
- Hits 353438 352107 -1331
+ Misses 45417 45310 -107
... and 154 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Documentation preview for this PR is ready! 🎉 |
4 tasks
|
merge conflict |
vbraun
pushed a commit
that referenced
this pull request
Apr 23, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description We make `sage.quadratic_forms` ready for modularized distributions by: - moving imports from some packages, such as `sage.rings.padics.factory`, into methods - using `lazy_import` to provide the methods of `QuadraticForm` implemented in separate modules - adding `# optional` annotations to doctests Also some improvements to the code style of doctests and the Sphinx markup of some docstrings have been made. This has been and can be tested by merging into: - #35095 **sagemath-polyhedra** ships vector spaces etc. and now also portions of `sage.quadratic_forms` – see #35095 /files#diff- f4c7c1beea87ae44c426de0a55459daef63b75b701b72bc136d88f4e7c9285cfR104 Resolves #35243 Part of: - #29705 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - Depends on #35248 - Depends on #35166 URL: #35305 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Deprecate the non-standard
base_change_toin favor of the standardchange_ringinside quadratic forms.📝 Checklist
⌛ Dependencies