New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PermutationGroup.is_transitive is broken #3544
Comments
comment:2
This wraps IsTransitive, which is assuming that the degree is 2:
However, the docstring for is_transitive is wrong. There is no method A.set() implemented. |
comment:3
Please always assign a milestone. Cheers, Michael |
comment:4
I would suggest the following: (a) There is no bug in is_transitive but the docstring is wrong. (b) a "set" method should be implemented for the class PermutationGroup. (c) Possibly a verbose option could be added which prints (if the group If this seems reasonable, I could try working on this. |
comment:5
I don't like this approach. Instead, you should be able to tell the permutation group what it is acting on, and all the functions should be consistent. This is part of my goal for my summer work with permutation groups. |
comment:7
Some remarks:
I think we view permutation groups as contained in S_n, which naturally acts on [1..n], so that should be the default. I think permutations groups should also at some point in the future be equipable with an action on any set. But the resulting object will be "a permutation group equipped with an action", and is_transitive will be defined relative to that. So for this ticket, we just need to decide on the default set acted on by a permutation group generated by a list of permutations. I think the most natural choice is the set {1,2, ..., n} given the embedding in S_n. Anyway, I've attached a patch that fixes the bug, and makes is_transitive() return whether or not the group is transitive on |
Attachment: trac_3544.patch.gz |
comment:9
Looks good to me! |
comment:10
Merged in Sage 3.3.alpha1 |
Huh? The cyclic group of order 2 acting on 3 letters is transitive?
CC: @aghitza
Component: algebra
Issue created by migration from https://trac.sagemath.org/ticket/3544
The text was updated successfully, but these errors were encountered: