Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookbook documentation chapter: coding theory #3624

Closed
wdjoyner opened this issue Jul 9, 2008 · 24 comments
Closed

cookbook documentation chapter: coding theory #3624

wdjoyner opened this issue Jul 9, 2008 · 24 comments

Comments

@wdjoyner
Copy link

wdjoyner commented Jul 9, 2008

I've put a draft for the coding theory chapter for the cookbook.tex document in
http://sage.math.washington.edu/home/wdj/cookbook/
To possibly make it easier, I've created this tarball of the directory:
http://sage.math.washington.edu/home/wdj/cookbook2008-07-09.tar.gz

Component: documentation

Author: Ralf Stephan

Branch/Commit: 66c7d05

Reviewer: Kannappan Sampath

Issue created by migration from https://trac.sagemath.org/ticket/3624

@wdjoyner wdjoyner added this to the sage-3.1 milestone Jul 9, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 10, 2008

comment:1

This is unrelated to coercion and should not be assigned against the coercion milestone. Right now 3.0.6 is the default milestone, so please assign new tickets against that milestone.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.1, sage-3.0.6 Jul 10, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 10, 2008

comment:2

Is this TeX code stand alone or is there a patch in there somewhere for the new cookbook? If so we should create the cookbook and migrate chapter by chapter over from the old construction manual. Once that is done we remove const.tex and all the other bits related to it.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title cookbook documentation chapter: coding theory [with proto-patch, needs review?] cookbook documentation chapter: coding theory Jul 10, 2008
@wdjoyner
Copy link
Author

comment:3

I put a standalone latex file there (http://sage.math.washington.edu/home/wdj/cookbook/coding-theory/sage-coding-cookbook.tex) for just that chapter (not in manual style) but also the full latex setup for a new subdirectory of SAGE_ROOT/devel/doc. I don't know how to make a patch to add a cookbook subdirectory to devel/doc. The programming guide discusses adding new files at http://sage.scipy.org/sage/doc/html/prog/node72.html The book http://hgbook.red-bean.com/hgbook.html is hard to search through since the index is for page numbers but the html is in sections, not page numbers.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Oct 29, 2008

fixes typos in sage-coding-cookbook.tex

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Oct 29, 2008

comment:4

Attachment: 3624-doc.patch.gz

Replying to @wdjoyner:

I put a standalone latex file there (http://sage.math.washington.edu/home/wdj/cookbook/coding-theory/sage-coding-cookbook.tex) for just that chapter (not in manual style) but also the full latex setup for a new subdirectory of SAGE_ROOT/devel/doc.

I've attached a patch to your file sage-coding-cookbook.tex. It mainly fixes typos. I'm still waiting for sage-3.1.4 to finish building on my machine, so at the moment I can't review the sample code in your file.

@sagetrac-mvngu sagetrac-mvngu mannequin changed the title [with proto-patch, needs review?] cookbook documentation chapter: coding theory [with proto-patch, needs review] cookbook documentation chapter: coding theory Oct 29, 2008
@williamstein williamstein changed the title [with proto-patch, needs review] cookbook documentation chapter: coding theory [with proto-patch, needs work] cookbook documentation chapter: coding theory Nov 28, 2008
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Mar 7, 2010

comment:6

Ticket #8466 supersedes the current ticket.

@sagetrac-mvngu sagetrac-mvngu mannequin changed the title [with proto-patch, needs work] cookbook documentation chapter: coding theory cookbook documentation chapter: coding theory Mar 7, 2010
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@rwst
Copy link

rwst commented Mar 20, 2014

Branch: u/rws/ticket/3624

@rwst
Copy link

rwst commented Mar 20, 2014

comment:10

I took the latest corrected version of the paper, converted it to ReST using pandoc, and fixed that document, including a few typos. I converted the EPS figures to PNG using inkscape. The file is included in the toctree and the general index under number theory because I didn't want a toplevel entry. Maybe replace number theory with discrete math?


New commits:

32fe924Trac #3624: added rst version of tex paper; include in indices

@rwst
Copy link

rwst commented Mar 20, 2014

Author: Ralf Stephan

@rwst
Copy link

rwst commented Mar 20, 2014

Commit: 32fe924

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@rwst
Copy link

rwst commented May 8, 2014

comment:12
sage -t --long src/doc/en/thematic_tutorials/coding_theory.rst
    Error: TAB character found at lines 860,864,865,.,.,.,1064
+Included in Sage is the group theory package GAP [GAP]_ and GUAVA [GUAVA]_, GA
P’s coding
+theory package. All of GUAVA’s functions can be accessed within Sage.
+   (calling Steve Linton’s C programs in GAP),
+#. Boolean-valueTraceback (most recent call last):
  File "/home/ralf/sage/local/bin/patchbot/patchbot.py", line 468, in test_a_ticket
    res = plugin(ticket, is_git=True, baseline=baseline, **kwds)
  File "/home/ralf/git/sage-patchbot/src/plugins.py", line 149, in non_ascii
    exclude_new(ticket, regex=r'[^\x00-\x7F]', msg="Non-ascii characters", **kwds)
  File "/home/ralf/git/sage-patchbot/src/plugins.py", line 143, in exclude_new
    raise ValueError(full_msg)
ValueError: Non-ascii characters inserted on 35 non-empty lines

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a4b82e6Merge branch 'develop' into t/3624/ticket/3624
48079fareplace tabs, nonascii chars

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2014

Changed commit from 32fe924 to 48079fa

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@KPanComputes
Copy link

comment:16

Could you please rebase this on top of current release (and/or tell me how to do it)? This would be immensely helpful.

/p/s/ This should be an easy review for me but I have forgotten how to rebase a branch on top of another.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

d1b2487Merge branch 'develop' into t/3624/ticket/3624

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2014

Changed commit from 48079fa to d1b2487

@KPanComputes
Copy link

Reviewer: Kannappan Sampath

@KPanComputes
Copy link

comment:18

I am setting this to Positive Review! Thank to the authors and editor for the great work on this branch!

@rwst
Copy link

rwst commented Aug 14, 2014

comment:19

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented Aug 15, 2014

comment:20

PDF docs don't build

l.14519 \end{gather}
                    
? 
! Emergency stop.
\math@cr@@@ ...@ \@ne \add@amps \maxfields@ \omit 
                                                  \kern -\alignsep@ \iftag@ ...
l.14519 \end{gather}
                    
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on thematic_tutorials.log.
 [23make[1]: *** [thematic_tutorials.pdf] Error 1
make[1]: Leaving directory `/home/release/Sage/src/doc/output/latex/en/thematic_tutorials'
]

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2014

Changed commit from d1b2487 to 66c7d05

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

66c7d053624: rename images, fix math

@rwst
Copy link

rwst commented Aug 15, 2014

comment:22

I really thought I had tested this.

@vbraun
Copy link
Member

vbraun commented Aug 16, 2014

Changed branch from u/rws/ticket/3624 to 66c7d05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants