notebook -- allow admin user to view any worksheet

[TimothyClemans]

User "admin" will be able to go to hostname/users and click on any listed user and have complete access to that user's worksheets.

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/3743

[TimothyClemans]

Attachment: sage-3743.patch.gz

[williamstein]

comment:2

REFEREE REPORT:

You determine whether a user is an admin with

           if self.username == 'admin' 

It would be better to determine whether a user is an admin by using the account_type() method of users. This is because a user with a username other than 'admin' can still be an admin; with the code you've written you would introduce a bug since suddenly certain admin-like things wouldn't work for such a user, but they should.

[TimothyClemans]

comment:3

I started out using user_type but for whatever reason for user admin it was returning 'user' so to get the functionality working at all I used the current work around.

[TimothyClemans]

comment:4

Attachment: sage-3743_2.patch.gz

[williamstein]

comment:5

Positive review

[sagetrac-mabshoff]

comment:6

Merged both patches in Sage 3.1.alpha1