Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Categories.Algebra over Semirings need suggestion #37594

Closed
1 task done
amanmoon opened this issue Mar 11, 2024 · 0 comments
Closed
1 task done

Extend Categories.Algebra over Semirings need suggestion #37594

amanmoon opened this issue Mar 11, 2024 · 0 comments

Comments

@amanmoon
Copy link
Contributor

amanmoon commented Mar 11, 2024

Problem Description

I am currently working on the implementation of matrix spaces and matrices over semirings. I encountered an issue when attempting to use the code that returns the category Algebras(NN.category()) The code resulted in an error, as it seems that the current implimentation of Algebra is only meant for rings and not for semirings.

Proposed Solution

As suggested by David Roe here

We would need to change the implementation of the parent to allow for a different category. A lot of parents have category=None as a keyword argument, which lets you set the category manually and chooses a reasonable default if you don't.
In practice, this is going to make it a bit difficult, since we'll need to edit the sage source code to get it work.

Alternatives Considered

We can set a new argument, structure, in the Algebras() class, which will have a default value of a ring. Based on this structure argument, it chooses which category with axiom to inherit.
This will solve the issue with less code modification but i am not sure, if this is the correct way to approach the problem?

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
@amanmoon amanmoon changed the title Extend Categories.Algebra over Semirings Extend Categories.Algebra over Semirings need suggestions Mar 11, 2024
@amanmoon amanmoon changed the title Extend Categories.Algebra over Semirings need suggestions Extend Categories.Algebra over Semirings need suggestion Mar 11, 2024
@amanmoon amanmoon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@amanmoon amanmoon reopened this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants