Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo numpy 2.0 compatibility hack from #38250 after numpy 1 is gone #38275

Open
dimpase opened this issue Jun 25, 2024 · 0 comments
Open

undo numpy 2.0 compatibility hack from #38250 after numpy 1 is gone #38275

dimpase opened this issue Jun 25, 2024 · 0 comments
Labels
c: numerical t: tests wishlist item

Comments

@dimpase
Copy link
Member

dimpase commented Jun 25, 2024

#38250 introduces runtime and tests compatibility with numpy 2.0

Once numpy 1 is phased out, this should be undone and converted to numpy 2.0 only tests

          Nitpicking, the string "# to ensure numpy 2.0 compatibility" is applied inconsistently. I suggest for it to be attached to the "if" statement line. I guess it will be clear if an `import numpy` statement had to be explicitly added.

Originally posted by @kiwifb in #38250 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: numerical t: tests wishlist item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dimpase