Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation for discriminant function for modular abelian varieties' endomorphism ring #3848

Closed
craigcitro opened this issue Aug 14, 2008 · 2 comments
Closed

Better documentation for discriminant function for modular abelian varieties' endomorphism ring #3848

craigcitro opened this issue Aug 14, 2008 · 2 comments
Assignees
@craigcitro
Labels
c: modular forms p: minor / 4 t: bug
Milestone
sage-3.1

Comments

@craigcitro
Copy link
Member

The discriminant function for the endomorphism ring of a modular abelian variety needs a bit of clarification in its documentation. Namely, the fact that the discriminant returned is off by a factor of 2^d isn't at all obvious, and we now clearly state it.

Component: modular forms

Issue created by migration from https://trac.sagemath.org/ticket/3848
@craigcitro craigcitro added this to the sage-3.1 milestone Aug 14, 2008
@craigcitro craigcitro self-assigned this Aug 14, 2008
@williamstein
Copy link
Contributor

comment:1

Attachment: trac-3848.patch.gz

@williamstein williamstein changed the title [needs instant review] Better documentation for discriminant function for modular abelian varieties' endomorphism ring Better documentation for discriminant function for modular abelian varieties' endomorphism ring Aug 14, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Aug 15, 2008

comment:2

Merged in Sage 3.1.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Aug 15, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigcitro craigcitro

Labels
c: modular forms p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.1
Development

No branches or pull requests
2 participants
@craigcitro @williamstein