New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[with SPKG] Wrap Bernstein 's primegen #3925
Comments
comment:1
I added some checks and doctests, and made Primes() use this. This is still a work-in-progress. TODO:
|
Attachment: primegen-0.97.spkg.gz |
comment:4
Attachment: trac-3925-spkg_deps.patch.gz I've added an attempt at an .spkg for primegen-0.97 as an attachment, and also took the liberty of patching (untested...) spkg/install and spkg/standard/deps to build it automatically when installing sage. (In the 'spkg_deps' patch.) I'm not entirely confident the build system of the library will work everywhere, since it is rather non-standard, but hopefully it is portable enough. The library is tiny, with the .spkg only 32KB, and the compiled (Linux x86_64) library only 17KB. Timing:
goes from 84.17s (without this spkg+patch) to 20.77s (with spkg+patch) on a 2GHz Opteron. |
comment:5
Attachment: trac-3925-primegen.patch.gz Hello Willem. I successfully installed the spkg and the second patch but I don't know how to install the first patch as it changes files not in the usual code tree. If you tell me how, I would like to test this. -- John |
comment:6
Hi John. The first patch isn't necessary to use the spkg. It's only for making a fresh 'make' of sage automatically build the spkg. I'm not too sure sure if that patch is right, actually; that part should probably be left to a release manager. |
comment:7
Replying to @wjp:
OK, I'll have another go sometime this weekend. I'm glad about the first patch, since I'm not really competent to say if it's right (though it looks ok). |
comment:8
To adopt this spkg as part of Sage
but this does not use the new PrimeGen class. I tried this (with the
which is slower but it's using a more stupid method to collect the |
comment:9
Changing this to "needs work" given John's latest comments. Note that "work" here would mean making the case to sage-devel that the spkg should be adopted, and asking for a vote. |
See http://cr.yp.to/primegen.html
Some code at http://thread.gmane.org/gmane.comp.python.cython.devel/2579/focus=2581
CC: @sagetrac-mvngu @sagetrac-kevin-stueve
Component: number theory
Issue created by migration from https://trac.sagemath.org/ticket/3925
The text was updated successfully, but these errors were encountered: