Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list_of_first_n() broken in interact.py #4037

Closed
aghitza opened this issue Sep 2, 2008 · 2 comments
Closed

list_of_first_n() broken in interact.py #4037

aghitza opened this issue Sep 2, 2008 · 2 comments
Assignees
@aghitza
Labels
c: interact p: minor / 4 t: bug
Milestone
sage-3.1.2

Comments

@aghitza
Copy link

aghitza commented Sep 2, 2008

In server/notebook/interact.py, the function list_of_first_n() claims to return n elements, but it returns n+1 of them. The attached trivial patch fixes the function and the doctests.

Component: interact

Issue created by migration from https://trac.sagemath.org/ticket/4037
@aghitza aghitza added this to the sage-3.1.2 milestone Sep 2, 2008
@aghitza aghitza self-assigned this Sep 2, 2008
@JohnCremona
Copy link
Member

comment:1

Attachment: 4037-interact_list_of_first_n.patch.gz

Ok, a simple out-by-one bug. Patch applies cleanly to 3.1.2.alpha3 and doctests in sage.server.notebook all pass.

OK by me, though I usually steer clear of notebook patches as I rarely use the notebook!

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 2, 2008

comment:2

Merged in Sage 3.1.2.alpha4

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Sep 2, 2008
@aghitza aghitza mentioned this issue Sep 2, 2008
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: interact p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.1.2
Development

No branches or pull requests
2 participants
@aghitza @JohnCremona