Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow finite field elements in SBox constructor #4144

Closed
malb opened this issue Sep 18, 2008 · 3 comments
Closed

allow finite field elements in SBox constructor #4144

malb opened this issue Sep 18, 2008 · 3 comments

Comments

@malb
Copy link
Member

malb commented Sep 18, 2008

make it so that this works:

sage: sr = mq.SR(1,1,1,4, allow_zero_inversions=True)
sage: S = mq.SBox([sr.sub_byte(e) for e in list(sr.k)])
sage: S
(6, 5, 2, 9, 4, 7, 3, 12, 14, 15, 10, 0, 8, 1, 13, 11)

Component: misc

Keywords: aes, sbox, mq

Issue created by migration from https://trac.sagemath.org/ticket/4144

@malb malb added this to the sage-3.2.1 milestone Sep 18, 2008
@malb malb self-assigned this Sep 18, 2008
@malb
Copy link
Member Author

malb commented Sep 18, 2008

Attachment: sbox_gfq.patch.gz

@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Nov 23, 2008

comment:2

The code does something that looks reasonable, and doctests pass. (I don't know enough crypto to be sure that this is a useful thing to do, so I'm relying on malb for that part.)

Positive review.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Nov 23, 2008

comment:3

Merged in Sage 3.2.1.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Nov 23, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant