Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ell_finite_field.py "long" doctest fails #4179

Closed
sagetrac-GeorgSWeber mannequin opened this issue Sep 23, 2008 · 4 comments
Closed

ell_finite_field.py "long" doctest fails #4179

sagetrac-GeorgSWeber mannequin opened this issue Sep 23, 2008 · 4 comments

Comments

@sagetrac-GeorgSWeber
Copy link
Mannequin

sagetrac-GeorgSWeber mannequin commented Sep 23, 2008

In the file "ell_finite_field.py" change the line 1013 from

        sage: for p in prime_range(10000):           #long time (~20s)

to

        sage: for p in prime_range(32768, 42768):           #long time (~20s)

to achieve the same intended amount of testing for the elliptic cirves code as such.
(But do not run into an --- as of this writing --- outstanding bug related to 16-Bit signed integers on Mac OS X 10.4.)

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/4179

@sagetrac-GeorgSWeber sagetrac-GeorgSWeber mannequin added this to the sage-3.1.3 milestone Sep 23, 2008
@sagetrac-GeorgSWeber sagetrac-GeorgSWeber mannequin self-assigned this Sep 23, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 23, 2008

comment:2

Georg,

are you planning to post an actual hg patch?

Cheers,

Michael

@JohnCremona
Copy link
Member

comment:3

I'm not so keen on making this change, since this test was put in originally to show that a previous bug was fixed. It is natural to use a sequence of primes starting at 2, but not so natural to use a sequence like prime_range(32768, 42768).

Given that we are tracking the root problem anyway, can we not live with this one doctest failure which only occurs on one type of machine with the long option anyway?

@JohnCremona
Copy link
Member

comment:4

PS this ticket also duplicates #3760.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 24, 2008

comment:5

Replying to @JohnCremona:

PS this ticket also duplicates #3760.

Ok, I agree with John here and am closing this as a duplicate of #3760. I did comment on that ticket and mentioned this ticket, so the info should not get lost.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin removed this from the sage-3.1.3 milestone Sep 24, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Sep 24, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant