Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postitive review] Update eclib to eclib-20080310.p6.spkg #4191

Closed
JohnCremona opened this issue Sep 24, 2008 · 5 comments
Closed

[postitive review] Update eclib to eclib-20080310.p6.spkg #4191

JohnCremona opened this issue Sep 24, 2008 · 5 comments

Comments

@JohnCremona
Copy link
Member

I applied the patch supplied by Arnaud Bergeron to use ${MAKE} instead of make. At the same time I changed one line in src/g0n/Makefile, adding ecnf to PROGS since otherwise that binary was being left behind after "make veryclean".

I seem to remember that mabshoff said that the effect would be negligible since my Makefiles use gnu-isms anyway, but here it is.

See also #3358.

I just checked that this installs ok on a fresh 3.1.3.alpha1 build. A fresh spkg is attached.

Component: packages: standard

Keywords: eclib

Issue created by migration from https://trac.sagemath.org/ticket/4191

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 24, 2008

comment:2

John,

please do not attach spkgs since the trac install (and all attachments) are backed up daily and a 1.5mb spkg is rather large. So I have deleted the spkg and it is now at

http://sage.math.washington.edu/home/mabshoff/eclib-20080310.p6.spkg

Cheers,

Michael

@JohnCremona
Copy link
Member Author

comment:3

Replying to @sagetrac-mabshoff:

John,

please do not attach spkgs since the trac install (and all attachments) are backed up daily and a 1.5mb spkg is rather large. So I have deleted the spkg and it is now at

http://sage.math.washington.edu/home/mabshoff/eclib-20080310.p6.spkg

Cheers,

Michael

Very sorry, I knew I would do something wrong. Next time I'll just put it somewhere and put in a link. Now I have a sagemath account that will be easier.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 25, 2008

comment:4

Everything looks good. I deleted on stray SPKG.txt~ from the main directory. Positive review.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 25, 2008

comment:5

Merged in Sage 3.1.3.alpha2

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Update eclib to eclib-20080310.p6.spkg [postitive review] Update eclib to eclib-20080310.p6.spkg Sep 25, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Sep 25, 2008
@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants