Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for problems with zero kernel and images #4239

Closed
sagetrac-fwclarke mannequin opened this issue Oct 3, 2008 · 2 comments
Closed

fix for problems with zero kernel and images #4239

sagetrac-fwclarke mannequin opened this issue Oct 3, 2008 · 2 comments
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-3.1.3

Comments

@sagetrac-fwclarke
Copy link
Mannequin

sagetrac-fwclarke mannequin commented Oct 3, 2008

Computation of kernels and images of linear transformations over GF(p) (p odd) and CC fails when the result is zero.
The patch solves the problem by adjusting FreeModule_submodule_with_basis_pid so that a tuple of generators gets changed into a list (something that happens anyway if check == True). New doctests have been included.

Component: algebra

Keywords: kernel, image

Issue created by migration from https://trac.sagemath.org/ticket/4239
@sagetrac-fwclarke sagetrac-fwclarke mannequin added this to the sage-3.1.3 milestone Oct 3, 2008
@sagetrac-GeorgSWeber
Copy link
Mannequin

sagetrac-GeorgSWeber mannequin commented Oct 5, 2008

comment:1

Attachment: sage-4239.patch.gz

Thumbs up!

Letting the new doctests run without the patch shows horrible behaviour indeed.

Please get this patch into 3.1.3.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 7, 2008

comment:2

Merged in Sage 3.1.3.alpha3

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Oct 7, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-3.1.3
Development

No branches or pull requests
0 participants