Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad error message in SupersingularModule constructor #4307

Closed
williamstein opened this issue Oct 16, 2008 · 5 comments
Closed

bad error message in SupersingularModule constructor #4307

williamstein opened this issue Oct 16, 2008 · 5 comments

Comments

@williamstein
Copy link
Contributor

sage: SupersingularModule(15)
Traceback (most recent call last):
...
ValueError: order of finite field must be a prime power

The error message should say something like:

NotImplementedError: supersingular module of non-prime level not yet implemented

Component: modular forms

Issue created by migration from https://trac.sagemath.org/ticket/4307

@aghitza
Copy link

aghitza commented Oct 18, 2008

comment:2

Having looked at the code in ssmod.py, it seems to me that any nontrivial functionality is only implemented for level 1 at the moment. Two things that I tried: dimension() and hecke_matrix().

The attached patch raises ValueErrors if the characteristic is not prime or if the level is not coprime to the characteristic, and a NotImplementedError if the level is > 1.

Extending the functionality in ssmod.py to general levels is right up my alley, so I'll look into doing it in the near future. The code could also use more documentation and tests.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 20, 2008

comment:3

Alex,

please add doctests that show the new behavior to the not yet existing class SupersingularModule(hecke.HeckeModule_free_module) docstring.

Cheers,

Michael

@aghitza
Copy link

aghitza commented Oct 20, 2008

comment:4

Attachment: trac4307-ssmod_init.patch.gz

Yes. Done, and replaced the patch.

@craigcitro
Copy link
Member

comment:5

Looks good.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 26, 2008

comment:6

Merged in Sage 3.2.alpha1

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Oct 26, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants