Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair to totallyreal_dsage #4372

Closed
jvoight opened this issue Oct 26, 2008 · 8 comments
Closed

Repair to totallyreal_dsage #4372

jvoight opened this issue Oct 26, 2008 · 8 comments
Assignees
@williamstein
Labels
c: number theory r: wontfix t: bug

Comments

@jvoight
Copy link

jvoight commented Oct 26, 2008

Two changes/updates to get totallyreal_dsage to work:

(1) Craig improved the totally real field enumeration, but changed the public incr() to increment().

(2) dsage had some update where wall_time of a job is returned as a datetime object.

totallyreal_dsage is still at a nodoctest status, so shouldn't require any (meaningful) review if the patch works (it's against 3.1.4).

JV

Component: number theory

Issue created by migration from https://trac.sagemath.org/ticket/4372
@jvoight jvoight added this to the sage-4.3.2 milestone Oct 26, 2008
@jvoight
Copy link
Author

jvoight commented Oct 26, 2008

Attachment: 10736.patch.gz

Attachment: 10735.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 27, 2008

comment:1

totallyreal_dsage is still at a nodoctest status, so shouldn't require any (meaningful) review if the patch works (it's against 3.1.4).

Any patch should be reviewed in detail regardless of nodoctest status or not. Is there a specific reason we shouldn't remove the nodoctest on that file now?

Cheers,

Michael

@jvoight
Copy link
Author

jvoight commented Oct 27, 2008

Attachment: 10737.patch.gz

@jvoight
Copy link
Author

jvoight commented Oct 27, 2008

comment:2

Any patch should be reviewed in detail regardless of nodoctest status or not.
Is there a specific reason we shouldn't remove the nodoctest on that file now?

Agreed. I'd say the code is still 'experimental'; it only most of the time works for me without extra effort, though this is probably because dsage itself keeps getting upgraded. What is the sage philosophy here? The code will never be used as a component in some thing else, but I thought I should still share it.

JV

@williamstein
Copy link
Contributor

comment:3

Agreed. I'd say the code is still 'experimental'; it only most of the time works
for me without extra effort, though this is probably because dsage itself
keeps getting upgraded.

Well that will happen at most one more time, since dsage development stopped.

@williamstein
Copy link
Contributor

comment:4

REFEREE:

I applied the first two patches no problem to 3.2.1.alpha2. The third patch fails to apply:

sage: hg_sage.apply('https://github.com/sagemath/sage-prod/files/10642366/10737.patch.gz')
Attempting to load remote file: https://github.com/sagemath/sage/files/ticket4372/10737.patch.gz?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import   "/home/was/.sage/temp/sage/25372/tmp_2.patch"
applying /home/was/.sage/temp/sage/25372/tmp_2.patch
patching file sage/rings/number_field/totallyreal_dsage.py
Hunk #1 FAILED at 296
1 out of 1 hunk FAILED -- saving rejects to file sage/rings/number_field/totallyreal_dsage.py.rej
abort: patch failed to apply
---

was@sage:~/build/sage-3.2.1.alpha1$ more devel/sage/sage/rings/number_field/totallyreal_dsage.py.rej 
--- totallyreal_dsage.py
+++ totallyreal_dsage.py
@@ -297,7 +297,7 @@

                     # Add the timings.
                     self.cputime += job[1].cpu_time
-                    self.walltime += job[1].wall_time
+                    self.walltime += job[1].wall_time.seconds

                     if write_result:
                         fsock = open(filename_start + str(job[0]).replace(' ','') + '.out', 'w')

Looks easy to fix... so I fix it. No problem.

I then enable doctesting and try the tests, but they totally hang in line 60:

Trying:
    dsage.worker()###line 60:_sage_    >>> dsage.worker()
Expecting:
    [...]
2008-11-28 17:54:57-0800 [-] Log opened.
2008-11-28 17:54:57-0800 [-] Log opened.
2008-11-28 17:54:57-0800 [-] Logging to file:  /home/was/.sage/dsage/worker.log
2008-11-28 17:54:57-0800 [-] Starting factory <sage.dsage.twisted.pb.ClientFactory instance at 0x2aab35eaa710>
2008-11-28 17:54:57-0800 [-] ==================================================
2008-11-28 17:54:57-0800 [-] DSAGE Worker
2008-11-28 17:54:57-0800 [-] Started with PID: 25788
2008-11-28 17:54:57-0800 [-] Connecting to localhost:8081
2008-11-28 17:54:57-0800 [-] Using SSL: True
2008-11-28 17:54:57-0800 [-] ==================================================
2008-11-28 17:54:57-0800 [Uninitialized] <gnutls.interfaces.twisted.TLSConnector instance at 0x2aab35eaa830> will retry in 2 seconds
2008-11-28 17:54:57-0800 [Uninitialized] Stopping factory <sage.dsage.twisted.pb.ClientFactory instance at 0x2aab35eaa710>
2008-11-28 17:55:00-0800 [-] Starting factory <sage.dsage.twisted.pb.ClientFactory instance at 0x2aab35eaa710>
2008-11-28 17:55:00-0800 [Uninitialized] <gnutls.interfaces.twisted.TLSConnector instance at 0x2aab35eaa830> will retry in 7 seconds
2008-11-28 17:55:00-0800 [Uninitialized] Stopping factory <sage.dsage.twisted.pb.ClientFactory instance at 0x2aab35eaa710>
2008-11-28 17:55:07-0800 [-] Starting factory <sage.dsage.twisted.pb.ClientFactory instance at 0x2aab35eaa710>
2008-11-28 17:55:07-0800 [Uninitialized] <gnutls.interfaces.twisted.TLSConnector instance at 0x2aab35eaa830> will retry in 22 seconds
2008-11-28 17:55:07-0800 [Uninitialized] Stopping factory <sage.dsage.twisted.pb.ClientFactory instance at 0x2aab35eaa710>
[waited 20 minutes and it is stuck hard]

I delete ~/.sage/dsage and try again. Doctesting finishes with some errors:

was@sage:~/build/sage-3.2.1.alpha1$ ./sage -t devel/sage/sage/rings/number_field/totallyreal_dsage.py
sage -t  devel/sage/sage/rings/number_field/totallyreal_dsage.pyGoing into testing mode...
Adding testing client...
2008-11-28 18:12:33-0800 [-] Log opened.
2008-11-28 18:12:33-0800 [-] Log opened.
2008-11-28 18:12:33-0800 [-] Logging to file:  /home/was/.sage/dsage/worker.log
2008-11-28 18:12:33-0800 [-] Traceback (most recent call last):
2008-11-28 18:12:33-0800 [-]   File "/home/was/build/sage-3.2.1.alpha1/local/bin/dsage_worker.py", line 1039, in <module>
2008-11-28 18:12:33-0800 [-]     main()
2008-11-28 18:12:33-0800 [-]   File "/home/was/build/sage-3.2.1.alpha1/local/bin/dsage_worker.py", line 1026, in main
2008-11-28 18:12:33-0800 [-]     privkey_file=options.privkey_file)
2008-11-28 18:12:33-0800 [-]   File "/home/was/build/sage-3.2.1.alpha1/local/bin/dsage_worker.py", line 734, in __init__
2008-11-28 18:12:33-0800 [-]     self.pubkey = keys.Key.fromFile(self.pubkey_file)
2008-11-28 18:12:33-0800 [-]   File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/conch/ssh/keys.py", line 60, in fromFile
2008-11-28 18:12:33-0800 [-]     return Class.fromString(file(filename, 'rb').read(), type, passphrase)
2008-11-28 18:12:33-0800 [-] IOError: [Errno 2] No such file or directory: '/home/was/.sage/dsage/dsage_key.pub'
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 51:
    sage: dsage.setup_all()
Exception raised:
    Traceback (most recent call last):
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[2]>", line 1, in <module>
        dsage.setup_all()###line 51:
    sage: dsage.setup_all()
    AttributeError: 'DistributedSage' object has no attribute 'setup_all'
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 53:
    sage: dsage.server()
Expected:
    [...]
Got:
    Going into testing mode...
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 58:
    sage: dsage.setup_worker()
Expected:
    [...]
Got:
    Worker configuration finished.
    <BLANKLINE>
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 60:
    sage: dsage.worker()
Expected:
    [...]
Got nothing
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 65:
    sage: Dtr = totallyreal_dsage()
Exception raised:
    Traceback (most recent call last):
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[6]>", line 1, in <module>
        Dtr = totallyreal_dsage()###line 65:
    sage: Dtr = totallyreal_dsage()
      File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/sage/rings/number_field/totallyreal_dsage.py", line 69, in __init__
        self.D = DSage()
    NameError: global name 'DSage' is not defined
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 94:
    sage: Dtr.enumerate(6, 15^6, 4)
Exception raised:
    Traceback (most recent call last):
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_2[2]>", line 1, in <module>
        Dtr.enumerate(Integer(6), Integer(15)**Integer(6), Integer(4))###line 94:
    sage: Dtr.enumerate(6, 15^6, 4)
    NameError: name 'Dtr' is not defined
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage/sage/rings/number_field/totallyreal_dsage.py", line 96:
    sage: Dtr.compile_fields()
Exception raised:
    Traceback (most recent call last):
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_2[3]>", line 1, in <module>
        Dtr.compile_fields()###line 96:
    sage: Dtr.compile_fields()
    NameError: name 'Dtr' is not defined
**********************************************************************
2 items had failures:
   5 of   7 in __main__.example_1
   2 of   4 in __main__.example_2
***Test Failed*** 7 failures.
For whitespace errors, see the file /home/was/build/sage-3.2.1.alpha1/tmp/.doctest_totallyreal_dsage.pyTraceback (most recent call last):
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/application/app.py", line 614, in run
    runApp(config)
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/scripts/twistd.py", line 23, in runApp
    _SomeApplicationRunner(config).run()
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/application/app.py", line 330, in run
    self.application = self.createOrGetApplication()
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/application/app.py", line 416, in createOrGetApplication
    application = getApplication(self.config, passphrase)
--- <exception caught here> ---
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/application/app.py", line 427, in getApplication
    application = service.loadApplication(filename, style, passphrase)
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/application/service.py", line 368, in loadApplication
    application = sob.loadValueFromFile(filename, 'application', passphrase)
  File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-packages/Twisted-8.1.0-py2.5-linux-x86_64.egg/twisted/persisted/sob.py", line 214, in loadValueFromFile
    exec fileObj in d, d
  File "dsage_server.tac", line 130, in <module>
    dsage_server, dsage_server_port, ssl = start_dsage_server(dsage_service)
  File "dsage_server.tac", line 93, in start_dsage_server
    cert = X509Certificate(open(SSL_CERT).read())
exceptions.IOError: [Errno 2] No such file or directory: '/home/was/.sage/dsage/pubcert.pem'

Failed to load application: [Errno 2] No such file or directory: '/home/was/.sage/dsage/pubcert.pem'


	 [3.6 s]
exit code: 1024
 
----------------------------------------------------------------------
The following tests failed:


	sage -t  devel/sage/sage/rings/number_field/totallyreal_dsage.py
Total time for all tests: 3.6 seconds

... so I try

sage: dsage.setup()

and try doctesting again and it hangs.

Any thoughts?

@jvoight
Copy link
Author

jvoight commented Nov 30, 2008

comment:5

Replying to @williamstein:

I'm not sure totallyreal_dsage has ever had its doctests pass. I see some error messages are because dsage has even changed since the doctests were written.

I'd like to keep this as nodoctest; it will be nontrivial to make the code easily usable to others, and yet I'd like to keep the code updated with my changes.

JV

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

comment:6

As of Sage 4.3.1, ticket #7975 removed dsage from the standard spkg repository. I'm closing this ticket as wontfix. If there's a need for using dsage, one could make dsage an optional package with doctests marked as optional.

@sagetrac-mvngu sagetrac-mvngu mannequin added r: wontfix and removed p: minor / 4 labels Feb 2, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin removed this from the sage-4.3.2 milestone Feb 2, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin removed the s: needs work label Feb 2, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Feb 2, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: number theory r: wontfix t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@williamstein @jvoight