Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage 3.1.4: magma related optional doctest failure in sage/rings/quotient_ring.py #4395

Closed
sagetrac-mabshoff mannequin opened this issue Oct 30, 2008 · 6 comments
Closed

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 30, 2008

sage -t -long -optional devel/sage/sage/rings/quotient_ring.py
**********************************************************************
File "/home/mabshoff/build-3.2.a1/sage-3.2.alpha1-iras/tmp/quotient_ring.py", line 647:
    sage: Q._magma_() # optional requires Magma
Expected:
    Affine Algebra of rank 2 over GF(2)
    Graded Reverse Lexicographical Order
    Variables: x, y
    Quotient relations:
    [
    x^2 + x,
    y^2 + y
    ]
Got:
    Affine Algebra of rank 2 over GF(2)
    Graded Reverse Lexicographical Order
    Variables: x, y
    Quotient relations:
    [
    0,
    0
    ]
**********************************************************************
1 items had failures:
   1 of   5 in __main__.example_23
***Test Failed*** 1 failures.
For whitespace errors, see the file /home/mabshoff/build-3.2.a1/sage-3.2.alpha1-iras/tmp/.doctest_quotient_ring.py
 [5.4 s]
exit code: 1024

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/4395

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.2.1 milestone Oct 30, 2008
@williamstein
Copy link
Contributor

comment:1

Apply this after #4394

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Oct 31, 2008

comment:2

Where is the patch?

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Oct 31, 2008

comment:3

This patch (one it is here :)) also likely fixes the following problem:

sage -t -long -optional devel/sage/sage/rings/polynomial/pbori.pyx
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.1.3.final/tmp/pbori.py", line 988:
    sage: B._magma_() # optional requires magma
Expected:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    x^2 + x,
    y^2 + y,
    z^2 + z
    ]
Got:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    0,
    0,
    0
    ]
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.1.3.final/tmp/pbori.py", line 1024:
    sage: B._magma_() # optional requires magma, indirect doctest
Expected:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    x^2 + x,
    y^2 + y,
    z^2 + z
    ]
Got:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    0,
    0,
    0
    ]
**********************************************************************

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Nov 9, 2008

comment:4

Attachment: sage-4395.patch.gz

Positive review. It fixes the original problem reported, but not as I suspected the issue in

devel/sage/sage/rings/polynomial/pbori.pyx

That issue is now #4482.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.2.1, sage-3.2 Nov 9, 2008
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Nov 9, 2008

comment:5

Merged in Sage 3.2.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Nov 9, 2008
@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants