Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A hack in preparsing files is dangerous/confusing #4474

Closed
williamstein opened this issue Nov 9, 2008 · 2 comments
Closed

A hack in preparsing files is dangerous/confusing #4474

williamstein opened this issue Nov 9, 2008 · 2 comments
Assignees
@sagetrac-cwitty
Labels
r: duplicate t: bug

Comments

@williamstein
Copy link
Contributor

There is a dangerous hack in preparser.py. Given input file:

load a.sage
load b.py

Then b.py will be loaded while the file is being parsed, and before a.sage is loaded. That would be very confusing. See the related #4473 and apply that patch before working on this.

Component: misc

Issue created by migration from https://trac.sagemath.org/ticket/4474
@williamstein williamstein added this to the sage-5.11 milestone Nov 9, 2008
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@a-andre
Copy link

a-andre commented May 1, 2014

comment:3

The hack has been removed in #7514.

@a-andre a-andre removed this from the sage-6.2 milestone May 1, 2014
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 5, 2014

comment:4

You must set it to positive_review in this case.

@vbraun vbraun closed this as completed May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-cwitty sagetrac-cwitty

Labels
r: duplicate t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vbraun @williamstein @jdemeyer @a-andre