Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polynomial interface improvements #4522

Closed
burcin opened this issue Nov 14, 2008 · 6 comments
Closed

polynomial interface improvements #4522

burcin opened this issue Nov 14, 2008 · 6 comments

Comments

@burcin
Copy link

burcin commented Nov 14, 2008

Attached patch makes the following changes to improve the user interface of the polynomial classes:

  • Remove .name() method, since .variable_name() already provides same functionality.
  • make the .degree() function of univariate polynomials accept one argument,
    the generator, to be consistent with the .degree() of multivariate
    polynomials.
  • Add an .is_monomial() method to univariate polynomials.

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/4522

@burcin burcin added this to the sage-3.2.1 milestone Nov 14, 2008
@burcin burcin self-assigned this Nov 14, 2008
@burcin
Copy link
Author

burcin commented Nov 14, 2008

comment:1

One more change I forgot to specify above:

  • make the .polynomial() function of univariate polynomials behave the same way as that of multivariate polynomials. (I.e., return a univariate polynomial with a coefficient ring in the rest of the generators of the same parent, which simply means returning self in this case.)

@williamstein
Copy link
Contributor

comment:2

REFEREE REPORT:

This looks very good. Positive review subject to you posting an additional patch that puts the name method back in and has a deprecation warning with a doctest of this. We'll delete that in a few months.

@williamstein williamstein changed the title polynomial interface improvements [with patch, positive review (subject to deprecation patch)] polynomial interface improvements Nov 28, 2008
@williamstein
Copy link
Contributor

comment:3

Oh yes, by the way, I doctested all of the rings directory after this patch and it works 100%.

@burcin
Copy link
Author

burcin commented Nov 28, 2008

Attachment: trac_4522-polynomial_interface.patch.gz

make the interface of polynomials more consistent

@burcin
Copy link
Author

burcin commented Nov 28, 2008

comment:4

New version of the patch with the deprecation warning, and doctests for it.

I'm marking this positivie review, since William didn't state that he wanted to see the patch again. :)

@burcin burcin changed the title [with patch, positive review (subject to deprecation patch)] polynomial interface improvements polynomial interface improvements Nov 28, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Nov 28, 2008

comment:5

Merged in Sage 3.2.1.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants