Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage 3.2.rc1: automorphism_group() doctest failure on 32 bit in sage/combinat/species/library.py #4531

Closed
sagetrac-mabshoff mannequin opened this issue Nov 15, 2008 · 9 comments

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Nov 15, 2008

sage -t  devel/sage/sage/combinat/species/library.py 
********************************************************************** 
File "/home/john/sage-3.2.rc1/devel/sage/sage/combinat/species/library.py", 
line 86: 
    sage: a.automorphism_group() 
Expected: 
    Permutation Group with generators [(), ()] 
Got: 
    Permutation Group with generators [()] 
********************************************************************** 

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/4531

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.2 milestone Nov 15, 2008
@sagetrac-GeorgSWeber
Copy link
Mannequin

sagetrac-GeorgSWeber mannequin commented Nov 16, 2008

comment:1

That seems to be a problem of how Sage displays/prints permutation groups. Internally, everything seems fine. I just produced such a group and I get:

sage: B = species.BinaryTreeSpecies()
sage: a = B.structures([1,2,3,4,5]).random_element(); a
(1*5)*((2*3)*4)
sage: grp = a.automorphism_group()
sage: grp
Permutation Group with generators [(), ()]
sage: grp.list()
[()]

The latter two lines are pretty inconsistent.

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Nov 16, 2008

comment:2

Mike Hansen mentioned in IRC that this is the expected output and will post a patch to fix this in the morning.

Cheers,

Michael

@sagetrac-GeorgSWeber
Copy link
Mannequin

sagetrac-GeorgSWeber mannequin commented Nov 16, 2008

comment:3

OK. Thanks for this info!

@williamstein
Copy link
Contributor

comment:4

I am fixing this by changing permutation groups to make their gens be canonicalized by default (meaning they are sorted and duplicates are removed). This is much more in the spirit of Sage. There is still the option to have the generators be exactly what is input (duplicates and all).

@williamstein
Copy link
Contributor

Attachment: sage-4531.patch.gz

@williamstein
Copy link
Contributor

Attachment: doc-4531.patch.gz

@williamstein
Copy link
Contributor

Attachment: sage-4531-part2.patch.gz

trivial followup

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Nov 18, 2008

comment:5

mhansen gave this patch a positive review assuming the doctests pass. Since they do I am changing the subject.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Nov 18, 2008

comment:6

Merged all three patches in Sage 3.2.rc2

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Nov 18, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants