Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR and containment broken #4560

Closed
robertwb opened this issue Nov 20, 2008 · 6 comments
Closed

SR and containment broken #4560

robertwb opened this issue Nov 20, 2008 · 6 comments

Comments

@robertwb
Copy link
Contributor

This is bad

sage: sqrt(2) in CC
False

CC: @mwhansen

Component: calculus

Issue created by migration from https://trac.sagemath.org/ticket/4560

@roed314
Copy link
Contributor

roed314 commented Jan 23, 2009

Attachment: 4560.gz

@burcin
Copy link

burcin commented Jan 23, 2009

comment:2

Though seeing SymbolicEquation in parent.pyx is very scary at first, this is a good solution. :)

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 23, 2009

comment:3

The above patch causes the following doctest failure in tut.tex:

There is one subtlety in defining complex numbers: as mentioned above,
the symbol \code{i} represents a square root of \minusone, but it is a
\emph{formal} square root of \minusone; it is not in the complex numbers.
Calling \code{CC(i)} returns the complex square root of \minusone.
%link
\begin{verbatim}
sage: i in CC
False

now returns true. After some discussion with William it was decided to change the doctest.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title SR and containment broken [needs documentation fix] SR and containment broken Jan 24, 2009
@roed314
Copy link
Contributor

roed314 commented Jan 24, 2009

Attachment: 4560-doc.patch.gz

Documentation fix

@roed314 roed314 changed the title [needs documentation fix] SR and containment broken SR and containment broken Jan 24, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 29, 2009

Rebased verison of Roed's patch

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 29, 2009

comment:6

Attachment: trac_4560.patch.gz

Merged 4560-doc.patch and trac_4560.patch in Sage 3.3.alpha3.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 29, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants