Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition between doctest creation and running #4706

Closed
sagetrac-mabshoff mannequin opened this issue Dec 5, 2008 · 5 comments
Closed

fix race condition between doctest creation and running #4706

sagetrac-mabshoff mannequin opened this issue Dec 5, 2008 · 5 comments

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Dec 5, 2008

With high -tp numbers (i.e. 16) on sage.math one will see similar issues to the one below:

sage -t -long devel/sage/sage/libs/symmetrica/symmetrica.pyx
  File "/scratch/mabshoff/release-cycle/sage-3.2.alpha0/tmp/.doctest_symmetrica.py", line 29
    >>> test_integer(Integer(1))###line 539:_sage_    >>> test_integer(1)
    ^
IndentationError: unexpected indent

This is likely a race condition between creating the file and the actual running of the doctest. The issue is not specific to -tp.

A potential solution might be to create all .doctest_$FOO files and then start running them. This might also fix the problem with

sage -t -long devel/sage/sage/symbolic/constants.pyx
 [0.1 s]

in Sage 3.2.1+ which is caused by no doctests being executed since (a) either there are no doctests in that file or (b) we are running optional doctests only.

Cheers,

Michael

don't apply anything!

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/4706

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-4.8 milestone Dec 5, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin self-assigned this Dec 5, 2008
@sagetrac-mabshoff

This comment has been minimized.

@koffie
Copy link

koffie commented Aug 23, 2011

comment:2

Attachment: trac_4706-scripts-repo.patch.gz

I think this is an old ticket which can be closed and has been fixed in the mean time. At least during the parralel builds I did (and I did quite a few this sage days already) I never saw this message.

@koffie

This comment has been minimized.

@mwhansen
Copy link
Contributor

comment:3

I tihnk this can be closed as well.

@mwhansen mwhansen removed this from the sage-4.8 milestone Dec 17, 2011
@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants