Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better fix for determinant bug with speed regression fix #4823

Closed
robertwb opened this issue Dec 18, 2008 · 5 comments
Closed

better fix for determinant bug with speed regression fix #4823

robertwb opened this issue Dec 18, 2008 · 5 comments
Assignees
@williamstein
Labels
c: linear algebra p: blocker / 1 t: bug
Milestone
sage-3.2.2

Comments

@robertwb
Copy link
Contributor

The fix at #3887 computes way to many primes, making det and hnf very slow. The attached patch resolves this issue and still gives correct output.

CC: @ClementPernet

Component: linear algebra

Issue created by migration from https://trac.sagemath.org/ticket/4823
@robertwb robertwb added this to the sage-3.2.2 milestone Dec 18, 2008
@robertwb
Copy link
Contributor Author

comment:1

Attachment: 4823-faster-fix.patch.gz

@ClementPernet
Copy link
Contributor

comment:2

Patch looks correct and passes doctests.

@craigcitro
Copy link
Member

comment:3

I think we need to leave this as "open" until mabshoff merges the patch.

@craigcitro craigcitro reopened this Dec 18, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Dec 18, 2008

comment:5

How about a title for this ticket?

Cheers,

Michael

@craigcitro craigcitro changed the title No title better fix for determinant bug Dec 18, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title better fix for determinant bug better fix for determinant bug with speed regression fix Dec 18, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Dec 18, 2008

comment:8

Merged in Sage 3.2.2.rc2

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Dec 18, 2008
@craigcitro craigcitro mentioned this issue Apr 16, 2010
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: linear algebra p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-3.2.2
Development

No branches or pull requests
4 participants
@craigcitro @robertwb @williamstein @ClementPernet