sage/modules/vector_modn_sparse_c.pxi: allocate_c_vector_modint can leak memory in case of failure

[sagetrac-mabshoff]

Look at

cdef int allocate_c_vector_modint(c_vector_modint* v, Py_ssize_t num_nonzero) except -1:
    """
    Allocate memory for a c_vector_modint -- most user code won't call this.
    """
    v.entries = <int*>sage_malloc(num_nonzero*sizeof(int))
    if v.entries == NULL:
        raise MemoryError, "Error allocating memory"
    v.positions = <Py_ssize_t*>sage_malloc(num_nonzero*sizeof(Py_ssize_t))
    if v.positions == NULL:
        raise MemoryError, "Error allocating memory"
    return 0

When the allocation for positions fails we will leak entries.

Cheers,

Michael

Component: memleak

Issue created by migration from https://trac.sagemath.org/ticket/4961

[rlmill]

Attachment: trac-4961.patch.gz

[sagetrac-mabshoff]

comment:3

Positive review.

Cheers,

Michael

[sagetrac-mabshoff]

comment:4

Merged in Sage 3.3.alpha2