Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[with patch positive review] kernels of integer matrices #5001

Closed
jhpalmieri opened this issue Jan 17, 2009 · 4 comments
Closed

[with patch positive review] kernels of integer matrices #5001

jhpalmieri opened this issue Jan 17, 2009 · 4 comments

Comments

@jhpalmieri
Copy link
Member

sage: id = matrix(ZZ, 2, 2, [[1, 0], [0, 1]]) 
sage: id.left_kernel()
Traceback
...
TypeError: Argument K (= Integer Ring) must be a field.

On the other hand, id.right_kernel() and id.kernel() both work, and id.kernel() actually computes the left kernel. Note also that the documentation for both left_kernel and right_kernel says that the answer will be a vector space, not a module over the integers; this should be fixed, too.

Component: linear algebra

Keywords: matrix, kernel

Issue created by migration from https://trac.sagemath.org/ticket/5001

@williamstein
Copy link
Contributor

Attachment: trac_5001.patch.gz

@jhpalmieri
Copy link
Member Author

comment:2

Looks good, all tests passed. A few comments: the documentation still says "vector space" when computing the kernel of an integer matrix, but I can live with that. Perhaps more seriously, if you don't apply patch #5089, then computing the kernel (or left_kernel or right_kernel) of a sparse integer matrix leads to a segmentation fault. Does this need to be investigated further?

@jhpalmieri jhpalmieri changed the title kernels of integer matrices [mostly positive review] kernels of integer matrices Jan 24, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 24, 2009

comment:3

Since #5089 is being merged I am changing this to a positive review. The documentation issue about vector spaces vs. modules should be addressed via a followup ticket.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [mostly positive review] kernels of integer matrices [with patch positive review] kernels of integer matrices Jan 24, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 24, 2009

comment:4

Merged in Sage 3.3.alpha2

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 24, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants