New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
equality testing in graphs should check "weighted" property #5003
Comments
Attachment: trac-5003_weighted_eq_graphs.patch.gz |
comment:1
Hey, I ran into some doctest failures w/ your new change. Specifically, around line 839 (in the docstring for weighted_ajacency_matrix(...)):
This fails. Specifically, G.weighted() returns false (which seems like its own bug.) And Also, the example starting at line 1180 (in the docstring for weighted(...):
Fails. Because of the change. The first of these issues, is a bug and should be fixed IMHO. The second issue is more subtle and disturbing. Particularly because it indicates that a valid example used to work, you will be breaking compatibility with code that works this way, and you should think about what the previous assumptions were, and if you can work around them with a fix. |
comment:2
Replying to @shumow:
Not so much a bug, as a typo in the doctest. If you don't say G is weighted, then just adding edges with weights shouldn't change that. In fact, that's the point of the other doctest.
...
Well, it's more like we're updating things to actually do it correctly. Before, weighted wasn't a property of graphs, and that test was kind of a warning about that. I don't know of any code that would be affected by this, but I think this is the right way to do things. |
Apply this patch second. |
comment:3
Attachment: trac-5003-followup.patch.gz Looks good to me. |
comment:4
Merged in Sage 3.3.alpha2. Cheers, Michael |
See:
http://groups.google.com/group/sage-support/browse_thread/thread/d01dd8082da28d52?hl=en
Component: graph theory
Issue created by migration from https://trac.sagemath.org/ticket/5003
The text was updated successfully, but these errors were encountered: