New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py dependency checking detects unexpected dependencies #5060
Comments
comment:1
I think that modifying the regex like this (adding two
|
some more thoughts
and
Here is a first attempt to fix this,
However, for some reason, it doesn't catch yes14.h nor yes17b. So this is not yet functional (nor elegant). Any suggestion is welcome. |
comment:4
Attachment: 5060-deps.patch.gz The original bug was due to the fact that "^ *" was only required for the first grouping. Given that more than one module could be cimported in a single statement, it took an extra loop in the parsing code as well. |
comment:5
This looks good. Man, that is one serious regular expression. |
comment:6
Merged in Sage 3.3.alpha2 Cheers, Michael |
comment:7
Hello, reading the code, I see another problem if ones has the following line in its .pyx:
I such a case, we'll look for a dependency mod#mycomment.pxd instead of mod.pxd. Otherwise, the patch solves the aforementioned problems. Cheers |
comment:8
Please do not reopen closed tickets -- it makes things much more difficult for Michael. Instead, just open a new one. I've opened #5103 for this. |
comment:9
Actually, I'm going to reclose this ticket, since the original issues reported are fixed, and I've opened #5104 for this new issue. |
comment:10
Oops. Mike, I'm closing your ticket as a dupe, since I spent more time reformatting the text in mine. |
using sage 3.2.3, I'm trying to build a new module with a .pxd file containing this line
note that the line is commented. The build fails with the following traceback
There is probably a problem with the regexp on line 228 of setup.py. One can reprouce the bug with this snipet
which results in
Component: build
Issue created by migration from https://trac.sagemath.org/ticket/5060
The text was updated successfully, but these errors were encountered: