Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete/Change SageX references to Cython #5094

Closed
kcrisman opened this issue Jan 25, 2009 · 7 comments
Closed

Delete/Change SageX references to Cython #5094

kcrisman opened this issue Jan 25, 2009 · 7 comments

Comments

@kcrisman
Copy link
Member

In 3.3.alpha0, there is still a reference to SageX in COPYING.txt. Any others should also be reported here.

Component: documentation

Issue created by migration from https://trac.sagemath.org/ticket/5094

@kcrisman kcrisman added this to the sage-3.4.1 milestone Jan 25, 2009
@kcrisman
Copy link
Member Author

comment:1

This is not a duplicate of #857; the reference is in the second line of the document.

@kcrisman
Copy link
Member Author

Attachment: COPYING.txt

This is a one-word change of SageX to Cython from the 3.3.alpha0 version of this file.

@kcrisman
Copy link
Member Author

comment:2

Here are the others I have found. Most would be trivial to fix, but I don't know if all these files are long for this world.

misc/cython.py
In addition to one that should be there, there is one that it not!

rings/integer_mod_ring.py
An author credit should have Cython added

rings/padics/tutorial.py
Brief ref

calculus/var.pyx
Two references at G = globals()

graphs/graph_fast.pyx
The title refers to it

misc/reset.pyx
Two references at G = globals()

misc/sagex_ds.pyx
Includes references but of course is NAMED after it
It appears to be used in misc/all.py and rings/polynomial/polynomial_compiled.pyx/.pxd, so need to change those in theory

rings/integer.pyx
Again a couple

rings/laurent_series_ring_element.pyx
Brief ref

rings/power_series_ring_element.pyx
Brief ref

rings/polynomial/polynomial_element.pyx
A couple references

ext/python.pxi
Quite a few references at the top

rings/real_rqdf.pyx
One ref, if this is even being kept

structure/parent_old.pyx
Several references, is this worth fixing?

libs/pari/gen.pyx
Brief ref

There were some in docs, but presumably that is not worth changing until after the Sphinx change:
ref/module-sage.rings.integer-mod-ring.html
ref/module-sage.rings.laurent-series-ring-element.html
ref/module-sage.rings.padics.tutorial.html
ref/module-sage.rings.polynomial.polynomial-element.html
ref/module-sage.rings.power-series-ring-element.html
ref/node343.html
tut/node53.html (two examples, in SAGE_ROOT/examples/programming/sagex - should that directory be renamed as well?)

@kcrisman
Copy link
Member Author

kcrisman commented Feb 2, 2009

Based on 3.3.alpha0

@kcrisman
Copy link
Member Author

kcrisman commented Feb 2, 2009

comment:3

Attachment: trac_5094.patch.gz

@kcrisman kcrisman changed the title Delete/Change SageX references to Cython Delete/Change SageX references to Cython [with patch and text, needs review] Feb 2, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 2, 2009

comment:4

Positive review. That it touches python.pxi is rather unfortunate, but oh well ....

I guess in the long term we need to convert python.pxi to a pxd.

One last thing: The "[with patch, needs review]" goes to the front of the summary.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Delete/Change SageX references to Cython [with patch and text, needs review] Delete/Change SageX references to Cython Feb 2, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.4.1, sage-3.3 Feb 2, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 2, 2009

comment:5

Merged in Sage 3.3.alpha4.

Cheers,

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant