add charset header to worksheet html header

[dandrake]

Right now, the html generated for a worksheet does not include a header specifying the encoding, which confuses browsers: http://groups.google.com/group/sage-support/t/3d4b400f5afe66fb

As suggested by the OP of that thread, we should add

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

to the worksheet html.

CC: @mwhansen

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/5211

[dandrake]

comment:1

The attached patch (trac_5211.patch) adds Content-Type headers to (I think) all of the pages generated by the notebook server...but it seems like to be sure, we should also get Twisted to add Content-Type headers to its HTTP response. I poked around trying to figure out how to do that, but I don't know enough about that side of things to change it appropriately.

Also, this ticket is closely related to #1477 and #2896.

And here's a W3C page on character encodings: http://www.w3.org/International/O-charset

[sagetrac-mabshoff]

comment:2

This would be nice to get into 3.3 since it causes trouble for IE users.

Dan: Please make sure to mark tickets with patches appropriately so that they get picked up by the right reports.

Cheers,

Michael

[sagetrac-mabshoff]

comment:3

Mike,

it would be nice if you could review this.

Cheers,

Michael

[dandrake]

comment:4

Replying to @sagetrac-mabshoff:

This would be nice to get into 3.3 since it causes trouble for IE users.

Dan: Please make sure to mark tickets with patches appropriately so that they get picked up by the right reports.

Okay. I set the milestone to 3.4.1 because I wasn't sure if you were still considering these kinds of tickets for 3.3, and I didn't add a "[with patch, needs review]" because it's not quite done -- we also need to get Twisted to add the correct header, and I don't know how to do that. I was going to ping some of the usual notebook suspects and ask for some help. I see you've already done that. :)

Also, before we charge ahead and merge this, perhaps we should try and find out if anyone uses notebooks not encoded in UTF-8...it seems like we already should be encoding everything UTF-8, but as our continuing problems with accents show, there is some potential for problems to crop up.

[sagetrac-mabshoff]

comment:5

Ok, if it isn't ready it should be marked as such. Any ticket with a patch should have the "with patch" marker since there is no way to find tickets with patch otherwise that I am aware of.

It sounds like this ticket will miss the boat in 3.3, but there is another, closely related ticket with patch that needs work at #4547 by Mike, so it seems likely that this will come up again in 3.4 or later. Fixing this once and for all would be nice since it otherwise impedes adopting of Sage in countries where they have funny accents or even dare not to use English at all :)

Cheers,

Michael

[dandrake]

comment:6

Ah, #4547 is exactly what I was looking for.

[dandrake]

Attachment: trac_5211.patch.gz

[dandrake]

comment:7

I've attached a new version of the patch, rebased against 3.4.alpha0.

[mwhansen]

comment:8

Since #4547 was what Dan needed, I can give this a positive review.

[sagetrac-mabshoff]

comment:9

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael