New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in FractionField conversion #5292
Comments
comment:1
This is because eval is being used in lines 585+ of multi_polynomial_libsingular.pyx . |
comment:2
It's probably bad that it's even using strings here, but this fixes things a bit... Now, the use of eval() here is bad... for example sage: sage: R. = QQ[]; S.<q,t> = R[]; F = FractionField(S); is still wrong. There are better ways of going about this but at least it doesn't crash. And I'm more OK with a False negative, but if this is accepted a new ticket should be created to follow up. |
Attachment: 5292-parsing-fix.patch.gz |
comment:3
With the patch applied to my 3.3.rc2 merge tree all doctests pass. Cheers, Michael |
comment:4
BAD
|
fixed the previous very broken patch. |
comment:5
Attachment: trac_5292-part2.patch.gz I've attached a patch addressing all my remarks. Somebody review this. Mabshoff -- apply both patches in order. |
comment:6
Looks good to me. |
comment:7
Ouch, sorry. Yeah, that's one "wart" that I'm glad is being moved: http://www.python.org/dev/peps/pep-3110/ I should have added a test, but as I mentioned I don't think this resolves the real issue here (and since I found exactly where the problem was I wanted to make note of it). |
comment:8
Merged both patches in Sage 3.3.rc2. Cheers, Michael |
On Feb 16, 2009, at 4:01 PM, Jason Bandlow wrote:
Component: algebra
Issue created by migration from https://trac.sagemath.org/ticket/5292
The text was updated successfully, but these errors were encountered: