Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xgcd for polynomial over GF(2) #5353

Closed
mwhansen opened this issue Feb 23, 2009 · 6 comments
Closed

add xgcd for polynomial over GF(2) #5353

mwhansen opened this issue Feb 23, 2009 · 6 comments

Comments

@mwhansen
Copy link
Contributor

Currently, this fails:

sage: R.<x> = GF(2)[]
sage: fr = ((x+1)/(x^3+x+1) + (x+1)/(x^3+x^2+1));
sage: fr.partial_fraction_decomposition() 
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)

/home/mhansen/.sage/temp/sage.math.washington.edu/19940/_home_mhansen__sage_init_sage_0.py in <module>()

/home/mhansen/sage-3.3.alpha0-sage.math-only-x86_64-Linux/local/lib/python2.5/site-packages/sage/rings/fraction_field_element.so in sage.rings.fraction_field_element.FractionFieldElement.partial_fraction_decomposition (sage/rings/fraction_field_element.c:3052)()

/home/mhansen/sage-3.3.alpha0-sage.math-only-x86_64-Linux/local/lib/python2.5/site-packages/sage/rings/polynomial/polynomial_element.so in sage.rings.polynomial.polynomial_element.Polynomial.inverse_mod (sage/rings/polynomial/polynomial_element.c:8191)()

/home/mhansen/sage-3.3.alpha0-sage.math-only-x86_64-Linux/local/lib/python2.5/site-packages/sage/rings/polynomial/polynomial_gf2x.so in sage.rings.polynomial.polynomial_gf2x.Polynomial_template.xgcd (sage/rings/polynomial/polynomial_gf2x.cpp:5685)()

/home/mhansen/sage-3.3.alpha0-sage.math-only-x86_64-Linux/local/lib/python2.5/site-packages/sage/rings/polynomial/polynomial_gf2x.so in sage.rings.polynomial.polynomial_gf2x.celement_xgcd (sage/rings/polynomial/polynomial_gf2x.cpp:3517)()

NotImplementedError: 

Component: commutative algebra

Issue created by migration from https://trac.sagemath.org/ticket/5353

@mwhansen
Copy link
Contributor Author

comment:1

Currently, in sage.libs.ntl.ntl_GF2X_linkage.pyx celement_xgcd just raises a NotImplementedError, but NTL does provide a xgcd for GF2X elements.

@mwhansen
Copy link
Contributor Author

Attachment: trac_5353.patch.gz

@mwhansen mwhansen assigned mwhansen and unassigned malb Feb 24, 2009
@sagetrac-ylchapuy
Copy link
Mannequin

sagetrac-ylchapuy mannequin commented Feb 25, 2009

comment:3

The patch seems good but why does

f.xgcd?

show another docstring?

@mwhansen
Copy link
Contributor Author

comment:4

This is due to the polynomial templating which allows many of the polynomial types to share lots of boilerplate code. The generic code for xgcd calls the celement_xgcd defined here.

@sagetrac-ylchapuy
Copy link
Mannequin

sagetrac-ylchapuy mannequin commented Mar 16, 2009

comment:5

ok with sage 3.4

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 25, 2009

comment:6

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 25, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.4.2, sage-3.4.1 Mar 25, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants