fix "from ... import *" in class QuadraticForm (cf #4470)

[tornaria]

There are a number of "from ... import *" in the new quadratic forms code. This messes up tab completion (among other issues).

The attached patch fixes the issue by explicitly listing every function defined in the quadratic forms files.

Component: quadratic forms

Issue created by migration from https://trac.sagemath.org/ticket/5403

[tornaria]

Attachment: patch.QF.fix_import_star.gz

patch to fix import * issues in quadratic forms

[tornaria]

comment:1

There are still some issues in the attached patch. I'm working on that now.

[tornaria]

Attachment: patch.QF.fix_import_star.2nd.gz

2nd version of the patch, stilll some issue with deepcopy

[sagetrac-mabshoff]

comment:2

This would be nice to fix since on every first startup after moving Sage or cloning python will complain about those imports.

I am also marking the patch as needs work until it is ready for review. That way the patch will not be lost :)

Cheers,

Michael

[tornaria]

Attachment: patch.QF.fix_import_star.3rd.gz

3rd version of the patch, tests pass now

[tornaria]

comment:3

In the 3rd patch I added a fix for issue with copying and caching which for some weird reason didn't show up before.

All quadratic_form tests pass with this patch applied (NOT incremental, just get the 3rd one).

[sagetrac-mabshoff]

comment:5

Positive review.

Cheers,

Michael

[sagetrac-mabshoff]

comment:6

Merged in Sage 3.4.rc0.

Cheers,

Michael

[sagetrac-mabshoff]

Attachment: trac_5403_patch.QF.fix_import_star.3rd.patch.gz

This is a properly named version of Gonzalo's third patch