Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving fraction field to new coercion broke old pickles #5419

Open
craigcitro opened this issue Mar 2, 2009 · 1 comment
Open

moving fraction field to new coercion broke old pickles #5419

craigcitro opened this issue Mar 2, 2009 · 1 comment

Comments

@craigcitro
Copy link
Member

At some point, fraction fields were moved over to the new coercion model, which is good -- except that it broke all the old pickles. This thread on sage-support is about someone having a problem with them: http://groups.google.com/group/sage-support/browse_thread/thread/b5519db45a141819

The problem is that the old pickles don't have _element_class or _element_constructor fields, and there was no factory function in place -- so unpickling tries to directly create the object, which totally fails. Putting the old __call__ method back in place is an ugly hack to get these to load, but it's not a good permanent solution.

CC: @burcin

Component: misc

Issue created by migration from https://trac.sagemath.org/ticket/5419

@craigcitro craigcitro self-assigned this Mar 2, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 2, 2009

comment:1

Hmm,

how did this escape the pickle jar doctest?

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin removed the c: algebra label Mar 2, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.4.1 milestone Mar 2, 2009
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants