Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coercion bug in perm groups #5583

Closed
robertwb opened this issue Mar 22, 2009 · 11 comments
Closed

coercion bug in perm groups #5583

robertwb opened this issue Mar 22, 2009 · 11 comments
Assignees
@wdjoyner
Labels
c: group theory p: major / 3 t: bug
Milestone
sage-8.8

Comments

@robertwb
Copy link
Contributor 

sage: PermutationGroup([(), (1,3)]).has_coerce_map_from( PermutationGroup([(), (1,2)]) )
True

CC: @tscrim

Component: group theory

Stopgaps: todo

Author: Frédéric Chapoton

Branch/Commit: 696b23b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/5583
@robertwb robertwb added this to the sage-5.11 milestone Mar 22, 2009
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@sagetrac-jakobkroeker
Copy link
Mannequin

sagetrac-jakobkroeker mannequin commented Aug 19, 2015

Stopgaps: todo

@fchapoton
Copy link
Contributor

comment:6

works in 8.8.b5:

sage: PermutationGroup([(), (1,3)]).has_coerce_map_from( PermutationGroup([(), (
....: 1,2)]) )

False

@fchapoton fchapoton removed this from the sage-6.4 milestone May 17, 2019
@jhpalmieri
Copy link
Member

comment:7

I agree. It works going back to Sage 8.3 (that's the oldest version I have installed), in both Python 2 and Python 3.

@fchapoton
Copy link
Contributor

Commit: 696b23b

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:8

I have decided to add a doctest, just to be safe.

New commits:

696b23btrac 5583 adding a doctest

@fchapoton
Copy link
Contributor

Branch: u/chapoton/5583

@fchapoton fchapoton added this to the sage-8.8 milestone Jun 1, 2019
@fchapoton
Copy link
Contributor

comment:10

green bot, please review this easy ticket

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2019

comment:11

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 5, 2019

Changed branch from u/chapoton/5583 to 696b23b

@vbraun vbraun closed this as completed in 859ebb6 Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdjoyner wdjoyner

Labels
c: group theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
7 participants
@wdjoyner @robertwb @vbraun @tscrim @jhpalmieri @jdemeyer @fchapoton